Skip to content

Commit

Permalink
provider/aws: Randomize DB Option Group Name to avoid name conflicts …
Browse files Browse the repository at this point in the history 
…in Travis CI
  • Loading branch information
@catsby
catsby committed May 12, 2016
1 parent baed5dd commit f70f778
Showing 1 changed file with 47 additions and 30 deletions.
77 changes: 47 additions & 30 deletions builtin/providers/aws/resource_aws_db_option_group_test.go
View file
Original file line number Diff line number Diff line change
Expand Up @@ -7,25 +7,27 @@ import (
"github.com/aws/aws-sdk-go/aws"
"github.com/aws/aws-sdk-go/aws/awserr"
"github.com/aws/aws-sdk-go/service/rds"
"github.com/hashicorp/terraform/helper/acctest"
"github.com/hashicorp/terraform/helper/resource"
"github.com/hashicorp/terraform/terraform"
)

func TestAccAWSDBOptionGroup_basic(t *testing.T) {
var v rds.OptionGroup
rName := fmt.Sprintf("option-group-test-terraform-%s", acctest.RandString(5))

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSDBOptionGroupDestroy,
Steps: []resource.TestStep{
resource.TestStep{
Config: testAccAWSDBOptionGroupBasicConfig,
Config: testAccAWSDBOptionGroupBasicConfig(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSDBOptionGroupExists("aws_db_option_group.bar", &v),
testAccCheckAWSDBOptionGroupAttributes(&v),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "name", "option-group-test-terraform"),
"aws_db_option_group.bar", "name", rName),
),
},
},
Expand All @@ -34,30 +36,31 @@ func TestAccAWSDBOptionGroup_basic(t *testing.T) {

func TestAccAWSDBOptionGroup_OptionSettings(t *testing.T) {
var v rds.OptionGroup
rName := fmt.Sprintf("option-group-test-terraform-%s", acctest.RandString(5))

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSDBOptionGroupDestroy,
Steps: []resource.TestStep{
resource.TestStep{
Config: testAccAWSDBOptionGroupOptionSettings,
Config: testAccAWSDBOptionGroupOptionSettings(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSDBOptionGroupExists("aws_db_option_group.bar", &v),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "name", "option-group-test-terraform"),
"aws_db_option_group.bar", "name", rName),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "option.#", "1"),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "option.961211605.option_settings.129825347.value", "UTC"),
),
},
resource.TestStep{
Config: testAccAWSDBOptionGroupOptionSettings_update,
Config: testAccAWSDBOptionGroupOptionSettings_update(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSDBOptionGroupExists("aws_db_option_group.bar", &v),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "name", "option-group-test-terraform"),
"aws_db_option_group.bar", "name", rName),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "option.#", "1"),
resource.TestCheckResourceAttr(
Expand All @@ -70,27 +73,28 @@ func TestAccAWSDBOptionGroup_OptionSettings(t *testing.T) {

func TestAccAWSDBOptionGroup_sqlServerOptionsUpdate(t *testing.T) {
var v rds.OptionGroup
rName := fmt.Sprintf("option-group-test-terraform-%s", acctest.RandString(5))

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSDBOptionGroupDestroy,
Steps: []resource.TestStep{
resource.TestStep{
Config: testAccAWSDBOptionGroupSqlServerEEOptions,
Config: testAccAWSDBOptionGroupSqlServerEEOptions(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSDBOptionGroupExists("aws_db_option_group.bar", &v),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "name", "option-group-test-terraform"),
"aws_db_option_group.bar", "name", rName),
),
},

resource.TestStep{
Config: testAccAWSDBOptionGroupSqlServerEEOptions_update,
Config: testAccAWSDBOptionGroupSqlServerEEOptions_update(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSDBOptionGroupExists("aws_db_option_group.bar", &v),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "name", "option-group-test-terraform"),
"aws_db_option_group.bar", "name", rName),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "option.#", "1"),
),
Expand All @@ -101,18 +105,19 @@ func TestAccAWSDBOptionGroup_sqlServerOptionsUpdate(t *testing.T) {

func TestAccAWSDBOptionGroup_multipleOptions(t *testing.T) {
var v rds.OptionGroup
rName := fmt.Sprintf("option-group-test-terraform-%s", acctest.RandString(5))

resource.Test(t, resource.TestCase{
PreCheck: func() { testAccPreCheck(t) },
Providers: testAccProviders,
CheckDestroy: testAccCheckAWSDBOptionGroupDestroy,
Steps: []resource.TestStep{
resource.TestStep{
Config: testAccAWSDBOptionGroupMultipleOptions,
Config: testAccAWSDBOptionGroupMultipleOptions(rName),
Check: resource.ComposeTestCheckFunc(
testAccCheckAWSDBOptionGroupExists("aws_db_option_group.bar", &v),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "name", "option-group-test-terraform"),
"aws_db_option_group.bar", "name", rName),
resource.TestCheckResourceAttr(
"aws_db_option_group.bar", "option.#", "2"),
),
Expand Down Expand Up @@ -243,18 +248,21 @@ func testAccCheckAWSDBOptionGroupDestroy(s *terraform.State) error {
return nil
}

const testAccAWSDBOptionGroupBasicConfig = `
func testAccAWSDBOptionGroupBasicConfig(r string) string {
return fmt.Sprintf(`
resource "aws_db_option_group" "bar" {
name = "option-group-test-terraform"
name = "%s"
option_group_description = "Test option group for terraform"
engine_name = "mysql"
major_engine_version = "5.6"
}
`
`, r)
}

const testAccAWSDBOptionGroupOptionSettings = `
func testAccAWSDBOptionGroupOptionSettings(r string) string {
return fmt.Sprintf(`
resource "aws_db_option_group" "bar" {
name = "option-group-test-terraform"
name = "%s"
option_group_description = "Test option group for terraform"
engine_name = "oracle-ee"
major_engine_version = "11.2"
Expand All @@ -267,11 +275,13 @@ resource "aws_db_option_group" "bar" {
}
}
}
`
`, r)
}

const testAccAWSDBOptionGroupOptionSettings_update = `
func testAccAWSDBOptionGroupOptionSettings_update(r string) string {
return fmt.Sprintf(`
resource "aws_db_option_group" "bar" {
name = "option-group-test-terraform"
name = "%s"
option_group_description = "Test option group for terraform"
engine_name = "oracle-ee"
major_engine_version = "11.2"
Expand All @@ -284,20 +294,24 @@ resource "aws_db_option_group" "bar" {
}
}
}
`
`, r)
}

const testAccAWSDBOptionGroupSqlServerEEOptions = `
func testAccAWSDBOptionGroupSqlServerEEOptions(r string) string {
return fmt.Sprintf(`
resource "aws_db_option_group" "bar" {
name = "option-group-test-terraform"
name = "%s"
option_group_description = "Test option group for terraform"
engine_name = "sqlserver-ee"
major_engine_version = "11.00"
}
`
`, r)
}

const testAccAWSDBOptionGroupSqlServerEEOptions_update = `
func testAccAWSDBOptionGroupSqlServerEEOptions_update(r string) string {
return fmt.Sprintf(`
resource "aws_db_option_group" "bar" {
name = "option-group-test-terraform"
name = "%s"
option_group_description = "Test option group for terraform"
engine_name = "sqlserver-ee"
major_engine_version = "11.00"
Expand All @@ -306,11 +320,13 @@ resource "aws_db_option_group" "bar" {
option_name = "Mirroring"
}
}
`
`, r)
}

const testAccAWSDBOptionGroupMultipleOptions = `
func testAccAWSDBOptionGroupMultipleOptions(r string) string {
return fmt.Sprintf(`
resource "aws_db_option_group" "bar" {
name = "option-group-test-terraform"
name = "%s"
option_group_description = "Test option group for terraform"
engine_name = "oracle-se"
major_engine_version = "11.2"
Expand All @@ -323,4 +339,5 @@ resource "aws_db_option_group" "bar" {
option_name = "XMLDB"
}
}
`
`, r)
}

0 comments on commit f70f778

Please sign in to comment.