Skip to content

Extraneous space for multiline args #132

Description

@bwhaley

First and foremost, thanks for this project! I've been using it successfully in my AWS Parameter Store shell project.

I've noticed that an extraneous space is added in values with new lines. Here's a reproducible example:

package main

import (
	"github.com/abiosoft/ishell"
)

func main() {
	shell := ishell.New()
	shell.AddCmd(&ishell.Cmd{
		Name: "test",
		Func: func(c *ishell.Context) {
			shell.Printf("Got: '%x'\n", c.Args[0])
		},
	})
	shell.Run()
}
>>> test "foo\
... bar"
Got: '666f6f200a626172'

In the hex output we see:

666f6f - foo
200a - <space><newline>
626172 - bar

The space here is unexpected. I did start looking through the code here but ran out of time before I figured out where it was happening.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions