core: fix downloader duplicating downloads #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Abiola Ibrahim <git@abiosoft.com> The downloader currently has undesired behaviour of downloading twice when fetching the possible redirect URL of the asset to be downloaded. This resolves it by ensuring the initial request is an HEAD request.
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Aug 10, 2024
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [abiosoft/colima](https://github.com/abiosoft/colima) | patch | `v0.7.0` -> `v0.7.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>abiosoft/colima (abiosoft/colima)</summary> ### [`v0.7.1`](https://github.com/abiosoft/colima/releases/tag/v0.7.1) [Compare Source](abiosoft/colima@v0.7.0...v0.7.1) #### Highlights This is an incremental release with bug fixes. - Interrupted disk image download will now resume on subsequent `colima start`. - Docker container port mapping to specific host IP addresses is now supported. For more details about v0.70 features, check [v0.70 release notes](https://github.com/abiosoft/colima/releases/tag/v0.7.0). #### Other Fixes - Disk image downloader no longer duplicating downloads. Fixes [#​1098](abiosoft/colima#1098) - Support for binding to host IP address in containers. Fixes [#​492](abiosoft/colima#492) - Ensure proper loading of docker deamon settings on startup. Fixes [#​902](abiosoft/colima#902) - Running multiple Colima profiles with k3s enabled. Fixes [#​1087](abiosoft/colima#1087) #### Commits - k3s: use random port for cluster API by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1088 - k3s: re-use default port for existing instances by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1090 - net: support forwarding to specific host IP addresses by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1091 - core: nested virtualization and other fixes by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1094 - build(deps): bump golang.org/x/term from 0.22.0 to 0.23.0 by [@​dependabot](https://github.com/dependabot) in abiosoft/colima#1095 - fix(docker): apply configuration on first boot by [@​milas](https://github.com/milas) in abiosoft/colima#1097 - core: fix downloader duplicating downloads by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1099 - core: update disk images by [@​abiosoft](https://github.com/abiosoft) in abiosoft/colima#1102 **Full Changelog**: abiosoft/colima@v0.7.0...v0.7.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098.
The downloader currently has undesired behaviour of downloading twice when fetching the possible redirect URL of the asset to be downloaded.
This resolves it by ensuring the initial request is an HEAD request.