core: ensure that the user defined VMType flag is respected for m3 devices
#1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abiosoft
approved these changes
Jul 1, 2024
|
Thanks for this. |
abiosoft
changed the title
VMType flag is respectedVMType flag is respected for m3 devices
|
Can it be released pls? We can't use vmType setting on M3 from yaml, it always uses |
A release would be prioritised. In the meantime, if you do install with brew you can install the development version with |
5 tasks
bradleyayers
added a commit
to bradleyayers/colima
that referenced
this pull request
Jul 4, 2024
This removes the special case logic for M3 macs that use the vz driver instead of qemu. A lot of people are having trouble with vz on M3 macs: - abiosoft#987 (comment) - abiosoft#1045 (comment) - abiosoft#985 (comment) - abiosoft#985 (comment) - abiosoft#985 (comment)
abiosoft
pushed a commit
that referenced
this pull request
Jul 4, 2024
This removes the special case logic for M3 macs that use the vz driver instead of qemu. A lot of people are having trouble with vz on M3 macs: - #987 (comment) - #1045 (comment) - #985 (comment) - #985 (comment) - #985 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I'm creating this to ensure that the
--vm-typeflag is being respected. I understand that at one point qemu had issues on M3 chips, however in my current company we're experiencing issues usingvz. As such, we've had to revert back toqemu, and it's worked a treat.To get it going currently we need to run
coilima start --edit, which is fine for testing, but being able to run start with qemu defined as the vm type and have that setting respected would be a game changer. Happy to work on this and improve if needed, but I think this should do the trick.