Finalize read_qplist_sk in GwrReader (AI-generated code) - #401
Merged
Conversation
tsaihsiaoyi
force-pushed
the
merge_develop
branch
from
June 16, 2026 08:23
15dbffa to
27f2e72
Compare
tsaihsiaoyi
force-pushed
the
merge_develop
branch
from
June 16, 2026 08:32
27f2e72 to
a24b1b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR finalizes the read_qplist_sk function implementation in GwrReader, ensuring correct calculation and extraction of sigxme, sigcmee0, and vxcme, as well as correct scaling of quasiparticle energies to eV. This is an AI-generated code change.