feat: add spanish locate #13

fernandoc83 · 2023-01-16T21:23:35Z

Adds "es" locale for Spanish translation.

abichinger · 2023-01-16T22:03:25Z

@fernandoc83, thank you for your contribution! :)

I'm going to review it in the next few days.

abichinger

Please run yarn lint-fix to resolve the linting errors.

And please change your commit message to this format (git commit --amend). vue-js-cron uses semantic-release to publish its packages and the format is required by semantic-release to work properly.

abichinger · 2023-01-18T16:50:26Z

core/src/locale/es.js

+      range: { text: '{{ start.text }}-{{ end.text }}' },
+      everyX: { text: 'todos/as {{ every.value }}' }
+    },
+    meses: {


the names of the properties should not be translated

Here is an example of how the locale should be structured:

// the accessor of a localized string is: {periodId}.{fieldId}.{cronType}.{position} // '*' can be used as a wildcard // periodId = year | month | week | day | hour | minute // fieldId = dayOfWeek | month | day | hour | minute // cronType = empty | value | range | everyX | * // position = prefix | text | suffix | * type Locale = { '{periodId}'?: { '{position}'?: string // prefix/text/suffix of period selection '{fieldId}'?: { '{cronType}'?: { '{positon}'?: string // prefix/text/suffix of field } } } }

Hi, sorry for the mistakes, still learning here... I commited the corrections but I'm not sure if I have to make a new pull request or this can work.

No problem, I'm glad you are contributing :)
Looks almost perfect, but I noticed one more detail.

There are still some English words for the cron expression * * * * *

This should be fixable by setting the following properties inside the localization object:

*.month.empty.text

*.day.empty.text

*.hour.empty.text

*.minute.empty.text

not sure if I have to make a new pull request or this can work

No, you don't have to make a new PR. You can squash you commits (How do I squash my last N commits together?).
Afterwards you can push your changes with git push --force

If that is too much work, I can also squash them, when I merge this PR.

fernandoc83 · 2023-01-20T21:29:34Z

I made the corrections for empty fields, it should be ok now!

abichinger · 2023-01-21T12:31:40Z

LGTM! Thanks again!

## [1.0.3](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/ant@1.0.2...@vue-js-cron/ant@1.0.3) (2023-01-21) ### Features * add quasar (vite) ([2b3de8a](2b3de8a)) * add spanish locale ([#13](#13)) ([b18d352](b18d352))

# [3.4.0](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/core@3.3.0...@vue-js-cron/core@3.4.0) (2023-01-21) ### Features * add quasar (vite) ([2b3de8a](2b3de8a)) * add spanish locale ([#13](#13)) ([b18d352](b18d352))

## [1.1.3](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/element-plus@1.1.2...@vue-js-cron/element-plus@1.1.3) (2023-01-21) ### Features * add quasar (vite) ([2b3de8a](2b3de8a)) * add spanish locale ([#13](#13)) ([b18d352](b18d352))

## [2.2.3](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/light@2.2.2...@vue-js-cron/light@2.2.3) (2023-01-21) ### Features * add quasar (vite) ([2b3de8a](2b3de8a)) * add spanish locale ([#13](#13)) ([b18d352](b18d352))

## [3.2.3](https://github.com/abichinger/vue-js-cron/compare/@vue-js-cron/vuetify@3.2.2...@vue-js-cron/vuetify@3.2.3) (2023-01-21) ### Features * add quasar (vite) ([2b3de8a](2b3de8a)) * add spanish locale ([#13](#13)) ([b18d352](b18d352))

abichinger · 2023-01-21T12:35:46Z

🎉 This PR is included in version 1.0.1 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2023-01-21T12:36:07Z

🎉 This PR is included in version 1.0.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2023-01-21T12:36:13Z

🎉 This PR is included in version 3.4.0 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2023-01-21T12:36:19Z

🎉 This PR is included in version 1.1.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2023-01-21T12:36:28Z

🎉 This PR is included in version 2.2.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

abichinger · 2023-01-21T12:36:40Z

🎉 This PR is included in version 3.2.3 🎉

The release is available on npm package (@latest dist-tag)

Your semantic-release bot 📦🚀

# 1.0.0 (2023-11-18) ### Bug Fixes * *.umd.cjs path ([47e6793](47e6793)) * adapt flavors to new core ([18fc5d0](18fc5d0)) * add periods, remove rank ([7342b12](7342b12)) * add quasar to readme ([500859e](500859e)) * **ant:** migrate to typescript and vite ([54b2443](54b2443)) * **core:** generation of index.d.ts ([8b59bde](8b59bde)) * **core:** set default value ([90e8136](90e8136)) * **core:** set hour range to 0-23 ([b4f3a6d](b4f3a6d)), closes [#5](#5) * **docs:** add base ([b7f673d](b7f673d)) * **docs:** add demo ([e8711c4](e8711c4)) * **element-plus:** migrate to typescript and vite ([7c44b00](7c44b00)), closes [#40](#40) * eslint errors ([8ffe203](8ffe203)) * export type CronCoreProps and CronLightProps ([bf5d825](bf5d825)) * fill result of splitArray ([7b09c1e](7b09c1e)) * force release ([f2700ae](f2700ae)) * improve language resolution ([67c8f20](67c8f20)) * keep no specific value ([2bb9c12](2bb9c12)) * **light:** use vite and typescript ([4f9e524](4f9e524)) * **light:** highlight on hover ([78657e2](78657e2)) * **light:** set text color ([8627362](8627362)) * move vue to devDependencies, ... ([c8ce618](c8ce618)) * overflow of v-list-item ([866174b](866174b)) * **quasar:** migrate to typescript ([b20f5fb](b20f5fb)), closes [#40](#40) * README ([e4bc6fd](e4bc6fd)) * remove @quasar/vite-plugin ([03c803a](03c803a)), closes [#29](#29) * remove cyclic type ([a632e25](a632e25)) * remove reexport of core.util ([5e86236](5e86236)) * run yarn lint-fix ([5def48b](5def48b)) * **selectedStr:** sort selected values ([1a2be37](1a2be37)), closes [#6](#6) * set period value to period.id ([185e1ec](185e1ec)) * Update README ([0228557](0228557)), closes [#26](#26) * use .mjs for rollup config ([1cb1349](1cb1349)) * use language code 'zh' ([a63a5a8](a63a5a8)) * **vuetify:** pass props ([5419124](5419124)) * **vuetify:** migrate to typescript and vite ([f898127](f898127)), closes [#40](#40) * **vuetify:** output css file ([546264e](546264e)) * **vuetify:** select click event ([066edb2](066edb2)) ### Features * add "disabled" option ([ef951fe](ef951fe)), closes [#38](#38) * add ant ([b53958c](b53958c)) * add china locale ([8248739](8248739)) * add customLocale ([ea80fb9](ea80fb9)) * add danish locale ([5631d9a](5631d9a)) * add element plus ([b4c62b1](b4c62b1)) * add format prop [#25](#25) ([1b42d11](1b42d11)) * add german translation ([e3b7df0](e3b7df0)) * add initialPeriod ([dcb7396](dcb7396)) * add isEmpty to useSelect ([3ea62ba](3ea62ba)) * add light package ([48a67dd](48a67dd)) * add Naive UI support [#26](#26) ([3eff0b9](3eff0b9)) * add named exports ([75f7f18](75f7f18)) * add no specific value [#25](#25) ([3beb67f](3beb67f)) * add period prefix and suffix ([d97c081](d97c081)) * add portuguese translation ([64fbe1e](64fbe1e)) * add quasar (vite) ([2b3de8a](2b3de8a)) * add spanish locale ([#13](#13)) ([b18d352](b18d352)) * core in typescript ([dd33ece](dd33ece)) * **core:** add setupCron and setupSelect ([a4cb6d8](a4cb6d8)) * **core:** export locale, add mergeLocale prop ([bd35287](bd35287)) * **core:** upgrade to vue3 ([96fe7e6](96fe7e6)) * **docs:** upgrade to vuepress@next ([ca8e9be](ca8e9be)) * **light:** add clearable ([b9ca4e2](b9ca4e2)) * **light:** upgrade to vue3 ([2d33143](2d33143)), closes [#4](#4) * translate into typescript ([2f8a214](2f8a214)) * use vuepress instead of docute ([aa66330](aa66330)) * **vuetify:** add chipProps ([d67086a](d67086a)) * **vuetify:** upgrade to vue3 and add CustomSelect ([486d419](486d419)), closes [#4](#4) ### BREAKING CHANGES * **light:** force major release * remove export of util * restructured exports * **vuetify:** no vue2 support * **light:** no vue2 support * **core:** no vue2 support * CronState changed

# 1.0.0 (2024-11-14) ### Bug Fixes * *.umd.cjs path ([47e6793](47e6793)) * adapt flavors to new core ([18fc5d0](18fc5d0)) * add periods, remove rank ([7342b12](7342b12)) * add quasar to readme ([500859e](500859e)) * **ant:** migrate to typescript and vite ([54b2443](54b2443)) * **core:** generation of index.d.ts ([8b59bde](8b59bde)) * **core:** set default value ([90e8136](90e8136)) * **core:** set hour range to 0-23 ([b4f3a6d](b4f3a6d)), closes [#5](#5) * **docs:** add base ([b7f673d](b7f673d)) * **docs:** add demo ([e8711c4](e8711c4)) * **element-plus:** migrate to typescript and vite ([7c44b00](7c44b00)), closes [#40](#40) * eslint errors ([8ffe203](8ffe203)) * every n-th segments [#49](#49) ([fca6bba](fca6bba)) * export type CronCoreProps and CronLightProps ([bf5d825](bf5d825)) * fill result of splitArray ([7b09c1e](7b09c1e)) * force release ([f2700ae](f2700ae)) * improve language resolution ([67c8f20](67c8f20)) * interface Period ([4bf8faa](4bf8faa)) * keep no specific value ([2bb9c12](2bb9c12)) * **light:** use vite and typescript ([4f9e524](4f9e524)) * **light:** highlight on hover ([78657e2](78657e2)) * **light:** set text color ([8627362](8627362)) * make selected values reactive [#51](#51) ([bbc5f85](bbc5f85)) * mark quasar/ant as external ([4b18f7e](4b18f7e)) * move vue to devDependencies, ... ([c8ce618](c8ce618)) * **naive-ui:** stop event propagation on clear ([da788a9](da788a9)) * overflow of v-list-item ([866174b](866174b)) * publish vue3 to latest ([2f171a3](2f171a3)) * quartz format error in zh-cn locale ([67f92e8](67f92e8)) * **quartz:** Day-of-Week values must be between 1 and 7 [#62](#62) ([f8cbe3a](f8cbe3a)) * **quasar:** migrate to typescript ([b20f5fb](b20f5fb)), closes [#40](#40) * README ([e4bc6fd](e4bc6fd)) * remove @quasar/vite-plugin ([03c803a](03c803a)), closes [#29](#29) * remove cyclic type ([a632e25](a632e25)) * remove reexport of core.util ([5e86236](5e86236)) * run yarn lint-fix ([5def48b](5def48b)) * **selectedStr:** sort selected values ([1a2be37](1a2be37)), closes [#6](#6) * set period value to period.id ([185e1ec](185e1ec)) * update da.ts [#67](#67) ([a2ce2b7](a2ce2b7)) * Update README ([0228557](0228557)), closes [#26](#26) * update READMEs ([8d5d038](8d5d038)) * use .mjs for rollup config ([1cb1349](1cb1349)) * use language code 'zh' ([a63a5a8](a63a5a8)) * **vuetify:** pass props ([5419124](5419124)) * **vuetify:** migrate to typescript and vite ([f898127](f898127)), closes [#40](#40) * **vuetify:** output css file ([546264e](546264e)) * **vuetify:** select click event ([066edb2](066edb2)) ### Features * add "disabled" option ([ef951fe](ef951fe)), closes [#38](#38) * add @vue-js-cron/prime ([9fd559c](9fd559c)) * add ant ([b53958c](b53958c)) * add china locale ([8248739](8248739)) * add customLocale ([ea80fb9](ea80fb9)) * add danish locale ([5631d9a](5631d9a)) * add element plus ([b4c62b1](b4c62b1)) * add event `update:period` [#47](#47) ([1015ed9](1015ed9)) * add format prop [#25](#25) ([1b42d11](1b42d11)) * add german translation ([e3b7df0](e3b7df0)) * add hebrew locale support ([#60](#60)) ([14b9fbd](14b9fbd)) * add initialPeriod ([dcb7396](dcb7396)) * add isEmpty to useSelect ([3ea62ba](3ea62ba)) * add korean translation ([658ebf0](658ebf0)) * add light package ([48a67dd](48a67dd)) * add Naive UI support [#26](#26) ([3eff0b9](3eff0b9)) * add named exports ([75f7f18](75f7f18)) * add no specific value [#25](#25) ([3beb67f](3beb67f)) * add period prefix and suffix ([d97c081](d97c081)) * add portuguese translation ([64fbe1e](64fbe1e)) * add quasar (vite) ([2b3de8a](2b3de8a)) * add Russian, French, Hindi and Japanese ([7b33b18](7b33b18)) * add spanish locale ([#13](#13)) ([b18d352](b18d352)) * add spring format [#68](#68) ([577e019](577e019)) * core in typescript ([dd33ece](dd33ece)) * **core:** add setupCron and setupSelect ([a4cb6d8](a4cb6d8)) * **core:** export locale, add mergeLocale prop ([bd35287](bd35287)) * **core:** upgrade to vue3 ([96fe7e6](96fe7e6)) * **docs:** upgrade to vuepress@next ([ca8e9be](ca8e9be)) * **element-plus:** add dropdown props [#55](#55) ([2f6aa84](2f6aa84)) * improve initial period selection [#64](#64) ([9321c70](9321c70)) * **light:** add clearable ([b9ca4e2](b9ca4e2)) * **light:** upgrade to vue3 ([2d33143](2d33143)), closes [#4](#4) * translate into typescript ([2f8a214](2f8a214)) * use vuepress instead of docute ([aa66330](aa66330)) * **vuetify:** add chipProps ([d67086a](d67086a)) * **vuetify:** upgrade to vue3 and add CustomSelect ([486d419](486d419)), closes [#4](#4) ### BREAKING CHANGES * - renamed `CronCoreProps.initialPeriod` to `CronCoreProps.period` - removed argument from `setupCron` * **light:** force major release * remove export of util * restructured exports * **vuetify:** no vue2 support * **light:** no vue2 support * **core:** no vue2 support * CronState changed

Feature: add spanish locate

c05a149

abichinger self-requested a review January 16, 2023 22:03

abichinger requested changes Jan 18, 2023

View reviewed changes

fernandoc83 and others added 5 commits January 18, 2023 17:36

Merge remote-tracking branch 'upstream/main'

bc2c6ff

ci: add commitlint workflow

03d330e

docs(readme): add contributing section

cfba968

Merge branch 'main' of https://github.com/fernandoc83/vue-js-cron

96dd6f3

Properties name and file format corrections

7dc8b31

fernandoc83 changed the title ~~Feature: add spanish locate~~ feat: add spanish locate Jan 19, 2023

fernandoc83 added 3 commits January 20, 2023 18:08

Properties name and file format corrections

a27eac4

Merge branch 'main' of https://github.com/fernandoc83/vue-js-cron

3a359b4

Spanish translation correction

3979b53

abichinger merged commit b18d352 into abichinger:main Jan 21, 2023

abichinger added the released label Jan 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: add spanish locate #13

feat: add spanish locate #13

Uh oh!

fernandoc83 commented Jan 16, 2023

Uh oh!

abichinger commented Jan 16, 2023

Uh oh!

abichinger left a comment

Uh oh!

abichinger Jan 18, 2023 •

edited

Loading

Uh oh!

fernandoc83 Jan 19, 2023

Uh oh!

abichinger Jan 20, 2023 •

edited

Loading

Uh oh!

fernandoc83 commented Jan 20, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

Uh oh!

feat: add spanish locate #13

feat: add spanish locate #13

Uh oh!

Conversation

fernandoc83 commented Jan 16, 2023

Uh oh!

abichinger commented Jan 16, 2023

Uh oh!

abichinger left a comment

Choose a reason for hiding this comment

Uh oh!

abichinger Jan 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fernandoc83 Jan 19, 2023

Choose a reason for hiding this comment

Uh oh!

abichinger Jan 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fernandoc83 commented Jan 20, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

abichinger commented Jan 21, 2023

Uh oh!

Uh oh!

abichinger Jan 18, 2023 •

edited

Loading

abichinger Jan 20, 2023 •

edited

Loading