GH-125 simplification : got rid of all the unwanted dependencies, fixed a few issues, and trimmed down the code #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, fixed a few issues, and trimmed down the code
9 tasks
francoisledroff
commented
Sep 30, 2022
| sig.initVerify(getPublicKey(publicKeyPaths[i])); | ||
| sig.update(data); | ||
| result = result && sig.verify(sign); | ||
| // TODO may be this is not the behavior you had in mind ? |
Author
There was a problem hiding this comment.
may be just providing a public interface such as boolean verifySignature(String message, String publicKeyPaths, String signatures) would be enough this aio-lib-java webhook module.
we could the let our end-user decide how she/he want to cache key-pair and validate using both or just one key-pair
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.