-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to pass custom domain for message-id generation #51
Conversation
Makes sense. I’ll update.
|
@abhishek-ram Pushed the updated code and unit tests. Please check. |
@abhishek-ram Gentle reminder :) |
Thanks, @abhishek-ram! I see the tests are failing for some reason, please let me know if that's something I broke, or maybe I can fix it. I ran the test suite before pushing and it was fine. |
I do not think it was your change, It looks like a version of a library got updated or something not sure. If you can figure it out that would be great. |
@abhishek-ram Yeah, it's not my change. I figured out the reason, the latest tests were executed using I just compared these two versions, there's a line change and that's exactly where the tests are failing. |
can we freeze the version of pylama in setup.py -> test_requires |
@abhishek-ram will you be able to make a release soon with these changes? |
Done 1.4.1 |
#50