Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to pass custom domain for message-id generation #51

Merged
merged 1 commit into from
Mar 15, 2022
Merged

Option to pass custom domain for message-id generation #51

merged 1 commit into from
Mar 15, 2022

Conversation

robincsamuel
Copy link
Contributor

#50

pyas2lib/as2.py Outdated Show resolved Hide resolved
pyas2lib/as2.py Show resolved Hide resolved
@robincsamuel
Copy link
Contributor Author

robincsamuel commented Mar 9, 2022 via email

@robincsamuel
Copy link
Contributor Author

@abhishek-ram Pushed the updated code and unit tests. Please check.

@robincsamuel
Copy link
Contributor Author

@abhishek-ram Gentle reminder :)

@abhishek-ram abhishek-ram merged commit c52091b into abhishek-ram:master Mar 15, 2022
@robincsamuel
Copy link
Contributor Author

Thanks, @abhishek-ram! I see the tests are failing for some reason, please let me know if that's something I broke, or maybe I can fix it. I ran the test suite before pushing and it was fine.

@abhishek-ram
Copy link
Owner

I do not think it was your change, It looks like a version of a library got updated or something not sure. If you can figure it out that would be great.

@robincsamuel
Copy link
Contributor Author

@abhishek-ram Yeah, it's not my change. I figured out the reason, the latest tests were executed using pylama@8.3.7 and our previous test execution was using pylama@8.3.8.

I just compared these two versions, there's a line change and that's exactly where the tests are failing.

@abhishek-ram
Copy link
Owner

can we freeze the version of pylama in setup.py -> test_requires

@robincsamuel
Copy link
Contributor Author

#52

@robincsamuel
Copy link
Contributor Author

@abhishek-ram will you be able to make a release soon with these changes?

@abhishek-ram
Copy link
Owner

Done 1.4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants