Skip to content

Ignore utf-8 decode error during logging #966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 11, 2022
Merged

Ignore utf-8 decode error during logging #966

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion proxy/http/handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ def _parse_first_request(self, data: memoryview) -> bool:
except Exception as exc:
logger.exception('Error parsing the request', exc_info=exc)
raise HttpProtocolException(
'Error when parsing request: %s' % data.tobytes().decode('utf-8'),
'Error when parsing request: %s' % data.tobytes().decode('utf-8', errors='ignore'),
)
if not self.request.is_complete:
return False
Expand Down