Repository navigation
Set partner portal favicon and verify app icon consistency - #248
Conversation
Lighthouse ·
|
| Page | FCP | LCP | CLS | TBT | JS | Total |
|---|---|---|---|---|---|---|
Latest (/latest) |
1.06 s | 3.47 s | 0.001 | 85 ms | 308 KiB | 596 KiB |
Article preview (/articles/…) |
1.07 s | 3.93 s | 0.005 | 189 ms | 312 KiB | 615 KiB |
Topics (/topics) |
1.07 s | 2.98 s | 0.000 | 106 ms | 309 KiB | 447 KiB |
Sources (/sources) |
1.06 s | 3.11 s | 0.000 | 153 ms | 322 KiB | 463 KiB |
Public profile (/users/…) |
1.06 s | 2.66 s | 0.009 | 81 ms | 270 KiB | 405 KiB |
Leaderboard (/leaderboard) |
0.91 s | 2.45 s | 0.000 | 116 ms | 266 KiB | 364 KiB |
Mobile reader · Three cold loads per page · Median timings · Largest transfer size.
Needs attention
| Page | Finding | Measured | Target / limit |
|---|---|---|---|
Latest (/latest) |
3.47 s | 2.50 s | |
Article preview (/articles/…) |
3.93 s | 2.50 s | |
Topics (/topics) |
2.98 s | 2.50 s | |
Sources (/sources) |
3.11 s | 2.50 s | |
Public profile (/users/…) |
2.66 s | 2.50 s |
Full reports and logs · 090c741 · Attempt 1
Backend unit coveragePASS · minimum combined coverage 67.60%. Tests: 5558 passed, 0 failed, 0 skipped. Source files: 348.
Unit coverage includes every backend workspace. PostgreSQL/Redis integration tests run separately. Commit: 090c741 · HTML, JSON, XML reports and job logs · attempt 1 |
PR reader API performanceResult: INCONCLUSIVE 2 inconclusive · 6 within threshold. Zero request failures across all six runs. Base Three independent GitHub-hosted ARM64 runners, each measuring base and PR sequentially with alternating order and isolated resources for every sample. 16 users, 60 seconds/run, 1,000 synthetic articles, cache off, five PgBouncer slots. Latency comparisonAll latency values are in milliseconds; lower is better. Values are medians of three runs.
Additional latency and throughput metricsEach cell shows base → PR. Latencies are in milliseconds.
Individual runs
How to interpret this reportRegressed / Improved: a p95 regression needs >20% and >20 ms increase in the medians and at least two head samples versus the base median. Improvements use the inverse threshold. Within threshold means the change did not meet both thresholds. Inconclusive: a within-revision p95 range >35% of its median and >20 ms is too noisy for a confident latency verdict. Inconclusive latency comparisons are non-blocking: the check passes without claiming an improvement. Confirmed regressions and test/report errors fail the PR gate. Throughput is descriptive: paced users do not measure maximum capacity. This uncached public API test does not establish production health, browser performance or worker capacity. Base and PR share a runner within each pair; three pairs use independent runners. Alternating order reduces host-assignment bias but cannot eliminate changes in host load over time. Full HTML/CSV reports and logs · attempt 1 |
|
1 participant
What changes and why?
The partner portal had no favicon or Apple touch icon metadata. It now uses the same shared DevFeed 32×32 PNG favicon and 180×180 PNG touch icon as the reader and admin app.
Browser regressions cover the reader, admin app, partner portal and both built extensions. They check a single declaration with the correct MIME type and dimensions, fetch and decode the images in the browser, and compare their bytes with the shared brand assets. Existing extension packaging tests also verify the 128×128 manifest icon. Brand assets and page layouts are unchanged.
Validation
Rollout notes
No API, database or configuration changes. This PR does not deploy the website or publish either extension package.
Ready for review