Fix issue where fit to bounds would be lost when changing document #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue doesn't affect vpype per se as documents are never changed during the lifetime of a viewer, but it does affect vsketch in cases where sketches change their own page size (e.g. the `quick_draw` example. Fixes #458
Codecov ReportBase: 94.73% // Head: 94.73% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #564 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 62 62
Lines 5681 5683 +2
Branches 767 768 +1
=======================================
+ Hits 5382 5384 +2
Misses 182 182
Partials 117 117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This issue doesn't affect vpype per se as documents are never changed during the lifetime of a viewer, but it does affect vsketch in cases where sketches change their own page size (e.g. the
quick_drawexample.Fixes #458
Checklist
blackandisort)mypyreturns no errorpytestsucceedshelpreference.rstmake clean && make htmlindocs/)