Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit improvements #541

Merged
merged 7 commits into from
Sep 30, 2022
Merged

Unit improvements #541

merged 7 commits into from
Sep 30, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Sep 29, 2022

Description

  • Added yd (yards), mi (miles) and km units (useful for displaying stats)
  • Added inch as synonym for in, which cannot be used in expressions (in is a keyword) (fixes Expression: in doesn't work (reserved keyword) #538)
  • Misc fixes in docstrings
  • Updated pyproject.toml for Poetry 1.2
  • Update deps.
  • API: added vp.format_length() (for stats and Rich output to come)

TODO:

  • check expression with "inch"
  • check doc

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

- Added yd (yards), mi (miles) and km units (useful for displaying stats)
- Added `inch` as synonym for `in`, which cannot be used in expressions (`in` is a keyword) (fixes #538)
- Misc fixes in docstrings
- Updated pyproject.toml for Poetry 1.2
- Update deps.

TODO:
- check expression with "inch"
- check doc
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 94.69% // Head: 94.72% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (c1b3242) compared to base (c06da3d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #541      +/-   ##
==========================================
+ Coverage   94.69%   94.72%   +0.03%     
==========================================
  Files          62       62              
  Lines        5631     5668      +37     
  Branches      810      818       +8     
==========================================
+ Hits         5332     5369      +37     
  Misses        182      182              
  Partials      117      117              
Impacted Files Coverage Δ
vpype_cli/decorators.py 95.23% <ø> (ø)
tests/test_utils.py 100.00% <100.00%> (ø)
vpype/utils.py 96.61% <100.00%> (+1.61%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

… docs)

- Moved doc deps back to pyproject.toml (using an optional group)
- Updated .readthedocs.yml and removed old files accordingly
- updated unit list in documentation (sync'd from code)
- improved coverage
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit 521bdd1 into master Sep 30, 2022
@abey79 abey79 deleted the unit-improvements branch September 30, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expression: in doesn't work (reserved keyword)
1 participant