Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue #434 where forlayer would set _n improperly #443

Merged
merged 2 commits into from
Mar 31, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 31, 2022

Description

forlayer would set _n improperly.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #443 (eb4cf03) into master (e5929a1) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   93.97%   93.98%           
=======================================
  Files          60       60           
  Lines        5298     5301    +3     
  Branches      776      776           
=======================================
+ Hits         4979     4982    +3     
  Misses        204      204           
  Partials      115      115           
Impacted Files Coverage Δ
tests/test_commands.py 99.03% <100.00%> (+<0.01%) ⬆️
vpype_cli/blocks.py 97.36% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5929a1...eb4cf03. Read the comment docs.

@abey79 abey79 merged commit 11ebcf1 into master Mar 31, 2022
@abey79 abey79 deleted the fix-forlayer-n-434 branch March 31, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant