Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added configs for the Calcomp Artisan plotter #418

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Mar 14, 2022

Description

Added configs for the Calcomp Artisan plotter

Thanks to Andee Collard and @ithinkido

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #418 (e7fbaf2) into master (aa8fdea) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head e7fbaf2 differs from pull request most recent head f60278b. Consider uploading reports for the commit f60278b to get more accurate results

@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   93.78%   93.75%   -0.03%     
==========================================
  Files          59       59              
  Lines        5165     5160       -5     
  Branches      766      719      -47     
==========================================
- Hits         4844     4838       -6     
- Misses        205      207       +2     
+ Partials      116      115       -1     
Impacted Files Coverage Δ
vpype/line_index.py 86.51% <0.00%> (-2.50%) ⬇️
vpype_cli/substitution.py 91.33% <0.00%> (-0.07%) ⬇️
vpype/model.py 91.72% <0.00%> (-0.03%) ⬇️
vpype_cli/operations.py 97.06% <0.00%> (+0.35%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa8fdea...f60278b. Read the comment docs.

@abey79 abey79 force-pushed the feature-artisan-config branch from e7fbaf2 to f60278b Compare March 25, 2022 14:27
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@abey79 abey79 merged commit 2964c17 into master Mar 25, 2022
@abey79 abey79 deleted the feature-artisan-config branch March 25, 2022 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant