Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: pagerotate command to rotate the page (geometries included) b… #404

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Feature: pagerotate command to rotate the page (geometries included) b… #404

merged 3 commits into from
Feb 22, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Feb 22, 2022 •
edited
Loading

Description

This PR implements the page rotate command to rotate the page (geometries included) by 90 degrees

Fixes #364

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@codecov
Copy link

codecov bot commented Feb 22, 2022 •
edited
Loading

Codecov Report

Merging #404 (fdbc620) into master (f69c7f0) will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
+ Coverage   93.72%   93.76%   +0.03%     
==========================================
  Files          59       59              
  Lines        5135     5161      +26     
  Branches      717      719       +2     
==========================================
+ Hits         4813     4839      +26     
  Misses        207      207              
  Partials      115      115
Impacted Files Coverage Δ
tests/test_commands.py 99.02% <100.00%> (+0.02%) ⬆️
vpype_cli/operations.py 97.06% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f69c7f0...fdbc620. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit 8c13579 into master Feb 22, 2022
@abey79 abey79 deleted the feature-pagerotate branch February 22, 2022 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: "page rotate" command
1 participant
@abey79