Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken backward compatibility with Document.empty_copy() #380

Merged
merged 2 commits into from
Jan 19, 2022

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jan 19, 2022

Description

#359 renamed Document.empty_copy() to Document.clone() for coherence with LineCollection. However, empty_copy() should have been left for backward compatibility. This PR restores this call.

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • added new command to reference.rst
    • RTD doc updated and building with no error (make clean && make html in docs/)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jan 19, 2022

Codecov Report

Merging #380 (9a47476) into master (8b70225) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #380   +/-   ##
=======================================
  Coverage   92.72%   92.72%           
=======================================
  Files          53       53           
  Lines        4534     4535    +1     
  Branches      636      636           
=======================================
+ Hits         4204     4205    +1     
  Misses        220      220           
  Partials      110      110           
Impacted Files Coverage Δ
vpype/model.py 92.13% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b70225...9a47476. Read the comment docs.

@abey79 abey79 merged commit d4472f5 into master Jan 19, 2022
@abey79 abey79 deleted the fix-doc-empty-copy branch January 19, 2022 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant