Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix page size auto-detect failing when using write with default HPGL device #328

Merged
merged 4 commits into from
Oct 31, 2021

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Oct 31, 2021

Description

Fixes #319

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #328 (2e7cb41) into master (5f3fd97) will increase coverage by 0.23%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #328      +/-   ##
==========================================
+ Coverage   92.08%   92.31%   +0.23%     
==========================================
  Files          50       50              
  Lines        3954     3970      +16     
  Branches      521      521              
==========================================
+ Hits         3641     3665      +24     
+ Misses        209      203       -6     
+ Partials      104      102       -2     
Impacted Files Coverage Δ
tests/test_hpgl.py 100.00% <100.00%> (ø)
vpype/config.py 97.87% <100.00%> (+6.56%) ⬆️
vpype/io.py 78.15% <100.00%> (+0.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3fd97...2e7cb41. Read the comment docs.

- added tests
- updated dependencies
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit ce8026b into master Oct 31, 2021
@abey79 abey79 deleted the fix-write-pagesize-infer-319 branch October 31, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

write command: cannot infer page size when it should in HPGL mode
1 participant