Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: lswap and lreverse commands #300

Merged
merged 4 commits into from
Jul 9, 2021
Merged

Conversation

abey79
Copy link
Owner

@abey79 abey79 commented Jul 8, 2021

Description

New feature: lswap and lreverse commands.

Also:

  • improved command testing stuff
  • updated dependences

Checklist

  • feature/fix implemented
  • code formatting ok (black and isort)
  • mypy vpype vpype_cli tests returns no error
  • tests added/updated and pytest succeeds
  • documentation added/updated
    • command docstring and option/argument help
    • README.md updated (Feature Overview)
    • CHANGELOG.md updated
    • RTD doc updated and building with no error (make clean && make html in docs/)

abey79 added 2 commits July 8, 2021 18:10
- Improved command testing stuff
- Updated dependencies (changed to >= for dev deps)
- Readme updated
- Updated CHANGELOG.md
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #300 (0c9bf49) into master (e5e1eca) will increase coverage by 0.30%.
The diff coverage is 97.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   91.85%   92.15%   +0.30%     
==========================================
  Files          50       50              
  Lines        3878     3938      +60     
  Branches      508      516       +8     
==========================================
+ Hits         3562     3629      +67     
+ Misses        210      206       -4     
+ Partials      106      103       -3     
Impacted Files Coverage Δ
vpype/layers.py 80.55% <66.66%> (+3.41%) ⬆️
tests/test_commands.py 99.62% <97.14%> (+0.01%) ⬆️
tests/test_layers.py 100.00% <100.00%> (ø)
vpype_cli/layerops.py 97.97% <100.00%> (+0.92%) ⬆️
vpype/io.py 76.84% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5e1eca...0c9bf49. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 9, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@abey79 abey79 merged commit ed26fb6 into master Jul 9, 2021
@abey79 abey79 deleted the feature-lswap-lreverse branch July 9, 2021 12:41
@abey79 abey79 mentioned this pull request Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant