-
-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added linesort two-op operation #266
Conversation
12750.22643475841 -> 5950.841189588275 in 0.080s
12750.22643475841 -> 5361.155188942335 in 6.169s Squeezed out 11% in 77x the time. |
Codecov Report
@@ Coverage Diff @@
## master #266 +/- ##
==========================================
- Coverage 91.72% 91.42% -0.31%
==========================================
Files 50 50
Lines 3794 3870 +76
Branches 495 509 +14
==========================================
+ Hits 3480 3538 +58
- Misses 210 223 +13
- Partials 104 109 +5
Continue to review full report at Codecov.
|
It's 20% less distance at a cost of 11x the time. Rewrote it in numpy. So a 12k pen distance dropped to a 5.9k then with 10x the time to do that it dropped 20% more to 4.9k. Taking 0.08 seconds initially to 0.93 seconds. |
@abey79 I'm not sure how to fix the codecov stuff. It yells at me anytime I try to mess with the testing stuff. I assume any test that invokes it would fix that. |
Kudos, SonarCloud Quality Gate passed! |
@abey79 I failed to jump through the required hoops, but this is pretty solid code. I am in no way attached to this integration, but much significant improvements to linesort might be code worth having. |
Yeah, I plan to integrate this in the next release. Hope to be able do that inside of the next couple of weeks. |
- removed `--work` (now relies on global `-vv` option) - added a couple of tests - CHANGELOG.md updated
Kudos, SonarCloud Quality Gate passed! |
Description
Adds in a flag for the linesort command to perform two-opt global distance minimization.
Checklist
black
andisort
)mypy vpype vpype_cli tests
returns no errorpytest
succeedshelp
make clean && make html
indocs/
)