Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional options #57

Merged
merged 9 commits into from
Sep 30, 2018
Merged

Additional options #57

merged 9 commits into from
Sep 30, 2018

Conversation

Meldanen
Copy link

@Meldanen Meldanen commented Sep 4, 2018

Hey,

Main thing is adding opacity to linestyle as it didn't work the way it was set up before (wouldn't pick up the changed opacity).

Thanks,
Alex

@Meldanen
Copy link
Author

Meldanen commented Sep 6, 2018

Hey,

I've also added a minInterval option to the Axis.

Thanks,
Alex

@abel533
Copy link
Owner

abel533 commented Sep 6, 2018

Thanks for your pr!
Your commit has compiled file. such as: bin/com/github/abel533/echarts/AbstractData.class
You need to delete these files. It is better to merge these commits into one commit.

@Meldanen
Copy link
Author

Meldanen commented Sep 7, 2018

I wasn't aware that. Sorry the mistakes, first pull request :p
I'll let you know as soon as I resolve the compiled file issue

@abel533
Copy link
Owner

abel533 commented Sep 16, 2018

代码缩进有问题,注意查看diff。

@Meldanen
Copy link
Author

Okay,

I'll let you know when I get the chance to fix the indentation

Thanks,
Alex

@Meldanen
Copy link
Author

Hi again,

If you are using Eclipse, can you share your preferences with me? It looks like I fixed most things but not everything.

Thanks,
Alex

@abel533 abel533 merged commit 7911c73 into abel533:master Sep 30, 2018
@abel533
Copy link
Owner

abel533 commented Sep 30, 2018

我用的 IDEA,没有eclipse。这个项目需要配置 Lombok 插件。

@Meldanen
Copy link
Author

Thank you!
I'll keep that in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants