[php] Allow passing php class names as strings to Syntax.instanceof()

abeaumont · Feb 15, 2018 · 235e8ef · 235e8ef
1 parent 4c1a7a9
commit 235e8ef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/std/php/Syntax.hx b/std/php/Syntax.hx
@@ -162,6 +162,7 @@ extern class Syntax {
         Haxe generates `Std.is(value, Type)` calls as `$value instanceof Type` automatically where possible.
         So you may need this only if you have a `Class` stored in a variable.
     **/
+    @:overload(function( value:AsVar<Dynamic>, phpClassName:AsVar<String> ) : Bool {})
     static function instanceof<V,C>( value:AsVar<V>,  type:AsVar<Class<C>> ) : Bool;
 
     /**

diff --git a/tests/unit/src/unit/TestPhp.hx b/tests/unit/src/unit/TestPhp.hx
@@ -193,6 +193,13 @@ class TestPhp extends Test
 		t(a.indexOf(fn2) < 0);
 		f(a.remove(fn2));
 	}
+
+	function testSyntaxInstanceof() {
+		var o = new ClosureDummy();
+		var phpClassName = Boot.castClass(ClosureDummy).phpClassName;
+		t(Syntax.instanceof(o, ClosureDummy));
+		t(Syntax.instanceof(o, phpClassName));
+	}
 }
 
 private class ClosureDummy {