Analyze dependencies during the build (Azure#4706)

abdulrahman305 · Aug 7, 2019 · 2a17ea5 · 2a17ea5
1 parent a8faa8b
commit 2a17ea5
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 9 deletions.
diff --git a/README.md b/README.md
@@ -1,10 +1,5 @@
 # Azure SDK for JavaScript
 
-| Component            | Build Status                                                                                                                                                                                |
-| -------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| Management Libraries | [![Build Status](https://dev.azure.com/azure-sdk/public/_apis/build/status/138?branchName=master)](https://dev.azure.com/azure-sdk/public/_build/latest?definitionId=138&branchName=master) |
-| Client Libraries     | [![Build Status](https://dev.azure.com/azure-sdk/public/_apis/build/status/614?branchName=master)](https://dev.azure.com/azure-sdk/public/_build/latest?definitionId=614&branchName=master) |
-
 This repository contains official JavaScript libraries and TypeScript definitions for Azure services. For documentation go to [Azure SDK for JavaScript documentation](https://aka.ms/js-docs).
 
 You can find a complete list of these libraries in [packages.md](https://github.com/Azure/azure-sdk-for-js/blob/master/packages.md).
@@ -49,7 +44,18 @@ Libraries which enable you to provision specific resources. They are responsible
 - Check [previous questions](https://stackoverflow.com/questions/tagged/azure-sdk-js) or ask new ones on StackOverflow using `azure-sdk-js` tag.
 
 ## Contributing
+For details on contributing to this repository, see the [contributing guide](CONTRIBUTING.md).
+
+This project welcomes contributions and suggestions. Most contributions require you to agree to a Contributor License Agreement (CLA) declaring that you have the right to, and actually do, grant us the rights to use your contribution. For details, visit
+https://cla.microsoft.com.
 
-For details on contributing to this repository, see the [contributing guide](https://github.com/Azure/azure-sdk-for-js/blob/master/CONTRIBUTING.md).
+When you submit a pull request, a CLA-bot will automatically determine whether you need to provide a CLA and decorate the PR appropriately (e.g., label, comment). Simply follow the instructions provided by the bot. You will only need to do this once across all repositories using our CLA.
+
+This project has adopted the [Microsoft Open Source Code of Conduct](https://opensource.microsoft.com/codeofconduct/). For more information see the [Code of Conduct FAQ](https://opensource.microsoft.com/codeofconduct/faq/) or contact [opencode@microsoft.com](mailto:opencode@microsoft.com) with any additional questions or comments.
+
+| Component            | Build Status                                                                                                                                                                                |
+| -------------------- | ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
+| Client Libraries     | [![Build Status](https://dev.azure.com/azure-sdk/public/_apis/build/status/614?branchName=master)](https://dev.azure.com/azure-sdk/public/_build/latest?definitionId=614&branchName=master) [![Dependencies](https://img.shields.io/badge/dependencies-analyzed-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/dependencies.html) |
+| Management Libraries | [![Build Status](https://dev.azure.com/azure-sdk/public/_apis/build/status/138?branchName=master)](https://dev.azure.com/azure-sdk/public/_build/latest?definitionId=138&branchName=master) |
 
 ![Impressions](https://azure-sdk-impressions.azurewebsites.net/api/impressions/azure-sdk-for-js%2FREADME.png)
diff --git a/eng/pipelines/client.yml b/eng/pipelines/client.yml
@@ -6,6 +6,6 @@ trigger: none
 pr: none
 
 jobs:
-  - template: ../../eng/pipelines/templates/jobs/archetype-sdk-client.yml
+  - template: templates/jobs/archetype-sdk-client.yml
     parameters:
       ServiceDirectory: $(ServiceDirectory)
diff --git a/eng/pipelines/templates/jobs/archetype-sdk-client.yml b/eng/pipelines/templates/jobs/archetype-sdk-client.yml
@@ -70,9 +70,19 @@ jobs:
           ward scan -d $(Build.SourcesDirectory) -c $(Build.SourcesDirectory)/.docsettings.yml
         displayName: "Verify Readmes"
 
+      - script: |
+          npm ci
+        workingDirectory: $(System.DefaultWorkingDirectory)/eng/tools/analyze-deps
+        displayName: "Install tool dependencies"
+
+      - script: |
+          node index.js --verbose --out "$(Build.ArtifactStagingDirectory)/dependencies.html"
+        workingDirectory: $(System.DefaultWorkingDirectory)/eng/tools/analyze-deps
+        displayName: "Analyze library dependencies"
+
       - script: |
           node common/scripts/install-run-rush.js install
-        displayName: "Install dependencies"
+        displayName: "Install library dependencies"
 
       - script: |
           node common/scripts/install-run-rush.js lint $(GeneratedPackageTargets)
@@ -87,7 +97,7 @@ jobs:
 
       - task: PublishPipelineArtifact@1
         condition: succeededOrFailed()
-        displayName: "Publish lint reports"
+        displayName: "Publish Report Artifacts"
         inputs:
           artifactName: reports
           path: $(Build.ArtifactStagingDirectory)