Skip to content

Commit

Permalink
Removing external dependency edges for graph (Azure#7332)
Browse files Browse the repository at this point in the history
  • Loading branch information
KarishmaGhiya authored Feb 11, 2020
1 parent b67506f commit 14842d0
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Azure SDK for JavaScript

[![Packages](https://img.shields.io/badge/packages-latest-blue.svg)](https://azure.github.io/azure-sdk/releases/latest/js.html) [![Dependencies](https://img.shields.io/badge/dependencies-analyzed-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/dependencies.html)[![DependencyGraph](https://img.shields.io/badge/dependencies-graph-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/InterdependencyGraph.html)
[![Packages](https://img.shields.io/badge/packages-latest-blue.svg)](https://azure.github.io/azure-sdk/releases/latest/js.html) [![Dependencies](https://img.shields.io/badge/dependencies-report-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/dependencies.html) [![DependencyGraph](https://img.shields.io/badge/dependencies-graph-blue.svg)](https://azuresdkartifacts.blob.core.windows.net/azure-sdk-for-js/dependencies/InterdependencyGraph.html)

This repository is for active development of the Azure SDK for JavaScript (NodeJS & Browser). For consumers of the SDK we recommend visiting our [public developer docs](https://docs.microsoft.com/en-us/javascript/azure/) or our versioned [developer docs](https://azure.github.io/azure-sdk-for-js).

Expand Down
21 changes: 16 additions & 5 deletions eng/tools/analyze-deps/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -158,17 +158,28 @@ const constructDeps = (pkgs) => {
return dependencies;
};

const dumpRushPackages = (rushPackages) => {
const dumpRushPackages = (rushPackages, internalPackages, external) => {
const dumpData = {};
for (const [pkgName, pkgInfo] of Object.entries(rushPackages)) {
const deps = Object.entries(pkgInfo.run || {})
.map(([name, version]) => ({ name, version }))
var newDep = [];
if (external) {
newDep = Object.entries(pkgInfo.run || {})
.map(([name, version]) => ({ name, version }));
}
else {
for (var name in pkgInfo.run) {
if (internalPackages.includes(name)) {
version = pkgInfo.run[name];
newDep.push({ name, version })
}
}
}

dumpData[`${pkgName}:${pkgInfo.ver}`] = {
name: pkgName,
version: pkgInfo.ver,
type: 'internal',
deps: deps
deps: newDep
};
}
return dumpData;
Expand Down Expand Up @@ -305,7 +316,7 @@ const main = async () => {

if (args.dump) {
const internalPackages = Object.keys(rushPackages);
const dumpData = dumpRushPackages(context.packages);
const dumpData = dumpRushPackages(context.packages, internalPackages, args.external);
const pnpmLock = await readPnpmLock(path.resolve(`${__dirname}/../../../common/config/rush/pnpm-lock.yaml`));
for (const pkgId of Object.keys(dumpData)) {
resolveRushPackageDeps(dumpData, internalPackages, pnpmLock, pkgId, args.external);
Expand Down

0 comments on commit 14842d0

Please sign in to comment.