Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cli usage info #55

Merged
merged 4 commits into from
Jun 28, 2023
Merged

fix: cli usage info #55

merged 4 commits into from
Jun 28, 2023

Conversation

sqin2019
Copy link
Contributor

No description provided.

@sqin2019 sqin2019 requested a review from a team as a code owner June 27, 2023 00:20
sailorlqh
sailorlqh previously approved these changes Jun 27, 2023
View reviewed changes
@sqin2019 sqin2019 mentioned this pull request Jun 27, 2023
Merged
sethvargo
sethvargo previously approved these changes Jun 27, 2023
View reviewed changes
sethvargo
sethvargo reviewed Jun 27, 2023
View reviewed changes
pkg/cli/cli_handle.go Outdated Show resolved Hide resolved
@sqin2019 sqin2019 dismissed stale reviews from sethvargo and sailorlqh via c93ed8a June 27, 2023 00:46
@sqin2019 sqin2019 requested a review from sailorlqh June 27, 2023 01:02
sethvargo
sethvargo reviewed Jun 27, 2023
View reviewed changes
pkg/cli/cli_handle.go Outdated Show resolved Hide resolved
@sqin2019 sqin2019 requested a review from sethvargo June 27, 2023 01:32
@sqin2019 sqin2019 mentioned this pull request Jun 27, 2023
Merged
@capri-xiyue
Copy link

capri-xiyue commented Jun 28, 2023 •
edited
Loading

Such CLI looks like after the do process, it cleans up some left resources, similar examples helm/helm#1920 and transferwise/pipelinewise#573. Feel the original aod cli do and aod cli cleanup interface is less confusing. Just by looking at the interface of CLI, I feel

  1. With --cleanup, the handle command does 1. DO 2 CLEAN UP
  2. Without --clean up, the handle command does 1. DO

But in fact, your logic is

  1. With --cleanup, the handle command does 1. CLEAN UP
  2. Without --clean up, the handle command does 1. DO

@sqin2019 sqin2019 changed the title fix: cli commands fix: cli usage info Jun 28, 2023
capri-xiyue
capri-xiyue previously approved these changes Jun 28, 2023
View reviewed changes
@sqin2019 sqin2019 mentioned this pull request Jun 28, 2023
Closed
sqin2019 added a commit that referenced this pull request Jun 28, 2023
@sqin2019
feat: aod cli cleanup workflow (#56)
5b4e1e9 
hold until #55 merges
@sqin2019 sqin2019 merged commit c96aa61 into main Jun 28, 2023
@sqin2019 sqin2019 deleted the sqin/fixcli branch June 28, 2023 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capri-xiyue capri-xiyue capri-xiyue approved these changes

@sailorlqh sailorlqh Awaiting requested review from sailorlqh

@sethvargo sethvargo Awaiting requested review from sethvargo

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sqin2019 @capri-xiyue @sethvargo @sailorlqh