Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validate cli #18

Merged
merged 3 commits into from
May 23, 2023
Merged

feat: add validate cli #18

merged 3 commits into from
May 23, 2023

Conversation

sqin2019
Copy link
Contributor

No description provided.

@sqin2019 sqin2019 requested a review from a team as a code owner May 22, 2023 22:18
@sqin2019 sqin2019 requested review from verbanicm, mattrandallbecker and yolocs and removed request for verbanicm and mattrandallbecker May 22, 2023 22:18
pkg/requestutil/request.go Show resolved Hide resolved
@sethvargo
Copy link
Contributor

sethvargo commented May 22, 2023

@sqin2019 if you'd like, you can:

go get -u github.com/abcxyz/pkg@main

and then add tab completions. This will be really helpful for browsing to files (you can use predict.Files to have tab completion for the local filesystem). See abcxyz/pkg#125 for some examples.

This can also be a follow-up if you want. We just added this functionality, so it's not a blocker.

@sqin2019
Copy link
Contributor Author

@sqin2019 if you'd like, you can:

go get -u github.com/abcxyz/pkg@main

and then add tab completions. This will be really helpful for browsing to files (you can use predict.Files to have tab completion for the local filesystem). See abcxyz/pkg#125 for some examples.

This can also be a follow-up if you want. We just added this functionality, so it's not a blocker.

Thanks, will check it out and follow up!

@sqin2019 sqin2019 merged commit 761c2a4 into main May 23, 2023
@sqin2019 sqin2019 deleted the sqin2019/issue16 branch May 23, 2023 16:24
verbanicm pushed a commit that referenced this pull request Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants