Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github to allowlist for Spicetify marketplace #119

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gnuhead-chieb
Copy link

No description provided.

@abba23
Copy link
Owner

abba23 commented Apr 13, 2023

'.*\.libsyn\.com', # podcasts

Is this really neccessary? Unless there's actually a larger number (maybe 5+) of subdomains, I'd like to avoid wildcards and use the specific subdomains in order to keep the list as strict as possible.

'.*\.github\.com', #Github (Spicetify marketplace)
'.*\.githubusercontent\.com', #Github (Spicetify marketplace)

Same question here. The entries should in any case be moved so the list stays sorted alphabetically by top level domain, then second level domain and so on. So github.com and githubusercontent.com would go after genius.com. Adding a space after the # would also help keep the comment format consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants