Skip to content

New VizFrame Chart control demo #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2024
Merged

Conversation

axelmohnen
Copy link
Contributor

Demo class: Z2UI5_CL_DEMO_APP_312
List of methods:
VIZ_FRAME
VIZ_DATASET
VIZ_FLATTENED_DATASET
VIZ_DIMENSIONS
VIZ_DIMENSION_DEFINITION
VIZ_MEASURES
VIZ_MEASURE_DEFINITION
VIZ_FEEDS
VIZ_FEED_ITEM

Demo Class: Z2UI5_CL_DEMO_APP_312
List of methods:
VIZ_FRAME
VIZ_DATASET
VIZ_FLATTENED_DATASET
VIZ_DIMENSIONS
VIZ_DIMENSION_DEFINITION
VIZ_MEASURES
VIZ_MEASURE_DEFINITION
VIZ_FEEDS
VIZ_FEED_ITEM
Demo class: Z2UI5_CL_DEMO_APP_312
List of methods:
VIZ_FRAME
VIZ_DATASET
VIZ_FLATTENED_DATASET
VIZ_DIMENSIONS
VIZ_DIMENSION_DEFINITION
VIZ_MEASURES
VIZ_MEASURE_DEFINITION
VIZ_FEEDS
VIZ_FEED_ITEM
Demo class: Z2UI5_CL_DEMO_APP_312
List of methods:
VIZ_FRAME
VIZ_DATASET
VIZ_FLATTENED_DATASET
VIZ_DIMENSIONS
VIZ_DIMENSION_DEFINITION
VIZ_MEASURES
VIZ_MEASURE_DEFINITION
VIZ_FEEDS
VIZ_FEED_ITEM
@axelmohnen
Copy link
Contributor Author

New VizFrame Chart control
Demo class: Z2UI5_CL_DEMO_APP_312
List of methods:
VIZ_FRAME
VIZ_DATASET
VIZ_FLATTENED_DATASET
VIZ_DIMENSIONS
VIZ_DIMENSION_DEFINITION
VIZ_MEASURES
VIZ_MEASURE_DEFINITION
VIZ_FEEDS
VIZ_FEED_ITEM

@oblomov-dev oblomov-dev merged commit 7d8efb8 into abap2UI5:main Dec 2, 2024
4 checks passed
@oblomov-dev
Copy link
Member

oblomov-dev commented Dec 2, 2024

@axelmohnen thanks for the PRs.

when i start the sample i get:
image

In my console i get the following error:
Screenshot 2024-12-02 at 12 23 55

I hope i did not mess something up with the PRs. Which UI5 version do you use?

PS: i deleted here the xmlns, otherwise i got an error:
https://github.com/abap2UI5/abap2UI5/pull/1605/files#diff-b1f5df6aaed439fd91385822aefae8daf51e6e7c7be416a8337917450bdafbf1R10425-R10426

@axelmohnen
Copy link
Contributor Author

Hi @oblomov-dev,
We are using local SAPUI5 version 1.108.19.

Maybe the issue comes from the different namspaces?
Do we have to maintain the NS with "xmlns:" or without?

image

@oblomov-dev
Copy link
Member

mhh then my version should be high enough.

xmlns is added automatically at a later point, so no need for that. i already deleted it.

@axelmohnen
Copy link
Contributor Author

Maybe this is an "content security policy" issue.
Could you please run the Vizframe chart demo from SAPUI5 samples.
https://sapui5.hana.ondemand.com/#/entity/sap.viz.ui5.controls.VizFrame/sample/sap.viz.sample.Column/code

Do you have the same behavior?

image

@oblomov-dev
Copy link
Member

ah overlooked this, thanks for the hint, fixed with:
abap2UI5/abap2UI5#1607

Now it works:
image

This is awesome — thanks a lot for the sample!

Currently, I create a lot of posts on LinkedIn when people contribute to showcase that this is a community-driven project. I'd be happy to create a post about this sample as well! If you’re okay with it, feel free to share your LinkedIn name so I can credit you as a contributor. Of course, no pressure if you’d prefer not to — totally fine either way. 😊

@axelmohnen
Copy link
Contributor Author

Great News!
Sure no problem.
Here is my LinkedIn profile:
linkedin.com/in/axel-mohnen-ab182a164

Thanks a lot
Axel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants