Skip to content

Conversation

@AGMASO
Copy link
Collaborator

@AGMASO AGMASO commented Oct 21, 2025

General Changes

  • Fixed cooldown period for staking AAVE

Developer Notes


Reviewer Checklist

Please ensure you, as the reviewer(s), have gone through this checklist to ensure that the code changes are ready to ship safely and to help mitigate any downstream issues that may occur.

  • End-to-end tests are passing without any errors
  • Code changes do not significantly increase the application bundle size
  • If there are new 3rd-party packages, they do not introduce potential security threats
  • If there are new environment variables being added, they have been added to the .env.example file as well as the pertinant .github/actions/* files
  • There are no CI changes, or they have been approved by the DevOps and Engineering team(s)

@AGMASO AGMASO requested review from foodaka and mgrabina October 21, 2025 12:43
@vercel
Copy link

vercel bot commented Oct 21, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
interface Ready Ready Preview Comment Oct 21, 2025 1:06pm

💡 Enable Vercel Agent with $100 free credit for automated AI reviews

const { data: stakeGeneralResult } = useGeneralStakeUiData(currentMarketData, stakeAssetName);

const stakeData = stakeGeneralResult?.[0];
const stakeCooldownSeconds = stakeData?.stakeCooldownSeconds || 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we were just showing default right?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were displaying a hardcoded value equal to 20 days. I updated to show the cooldown value coming from the SC, and giving a hardcoded fallback equal to 7 days

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I’m thinking that the proposal only changed the cooldown period for AAVE, so I need to adjust the fallback to make sure it doesn’t affect other scenarios.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we read from the contract directly?

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

@github-actions
Copy link

📦 Next.js Bundle Analysis for aave-ui

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants