Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused _transfer #314

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix: remove unused _transfer #314

merged 1 commit into from
Apr 24, 2023

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2023 •
edited by ghost
Loading

  • Removed _transfer function is not required and not used; no codepath depends on it nor is it overriding any interface.

Closes #317

@ghost ghost requested review from miguelmtzinf, foodaka, Zer0dot and The-3D as code owners April 21, 2023 19:40
@height
Copy link

height bot commented Apr 21, 2023

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@Zer0dot
Copy link
Contributor

Zer0dot commented Apr 21, 2023

LGTM, no use keeping it there for no reason.

@miguelmtzinf miguelmtzinf merged commit 5bf3469 into main Apr 24, 2023
@miguelmtzinf miguelmtzinf deleted the fix/gho-atoken-remove-extra-transfer branch April 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foodaka foodaka Awaiting requested review from foodaka foodaka is a code owner

@The-3D The-3D Awaiting requested review from The-3D

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GhoAToken._transfer() internal function is not being used or neccesary
2 participants
@Zer0dot @miguelmtzinf