Skip to content
This repository was archived by the owner on Dec 9, 2025. It is now read-only.

Conversation

@alexandre-abrioux
Copy link
Contributor

@alexandre-abrioux alexandre-abrioux commented Mar 8, 2021

cherry-picked from #114

I had to fix the eslint config to be able to commit because, as you can see here in the CI the command yarn lint is broken.

The issue comes from the fact that prettier/@typescript-eslint is still used in the project while it has been deprecated (see here).

However, I could not make it work by just modifying the .eslintrc.json, I think it is due to this issue: jaredpalmer/tsdx#498 (comment). tsdx doesn't seem to take into account the extends part of the .eslintrc.json config file. I had to migrate the config to the package.json file. It works for me now!

as suggested by @sakulstra in #114 (comment)

would you mind reopening a pr, cherry picking the lint changes?

@sakulstra sakulstra merged commit 5638f5f into aave:master Mar 8, 2021
@sakulstra
Copy link
Contributor

thx for taking the time @alexandre-abrioux!

@alexandre-abrioux alexandre-abrioux deleted the fix-eslint branch March 8, 2021 15:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants