Skip to content

Convert to use Central Package Management#973

Merged
EdwardCooke merged 1 commit into
aaubry:masterfrom
lahma:cpm
Sep 13, 2024
Merged

Convert to use Central Package Management#973
EdwardCooke merged 1 commit into
aaubry:masterfrom
lahma:cpm

Conversation

@lahma

@lahma lahma commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

Now single place to have packages and their versions. See https://devblogs.microsoft.com/nuget/introducing-central-package-management/ for information about the feature.

The versions should be the same as before, didn't include any version updates, but should be easier/clearer in the future after this.

@lahma lahma marked this pull request as ready for review September 6, 2024 18:19
@EdwardCooke

Copy link
Copy Markdown
Collaborator

This is an interesting idea. In the most recently merged PR we cleaned up some unused references, can you rebase?

@lahma lahma force-pushed the cpm branch 3 times, most recently from cc1ecf4 to 6c97eeb Compare September 12, 2024 05:33
@lahma

lahma commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

Rebased, I removed some unnecessary references from projects and also targeted benchmark projects just against net8.0 for easiest dependency resolving. I think it should suffice to benchmark against modern runtime.

@EdwardCooke

Copy link
Copy Markdown
Collaborator

Thanks. However. We do benchmark against net47. I do agree targeting the latest net 80 framework as well.

@lahma

lahma commented Sep 12, 2024

Copy link
Copy Markdown
Contributor Author

I restored the net47 target (I think this should ideally be net472 as 4.7.2 is mainstream and comes with the OSs).

@EdwardCooke EdwardCooke merged commit f323881 into aaubry:master Sep 13, 2024
@lahma lahma deleted the cpm branch September 13, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants