Bring back stack trace to YamlException.ToString

[rosieks]

This PR introduce Reason property in YamlException to bring back default functionality of ToString method.
Fixes #999

[liskin]

Why not just use https://learn.microsoft.com/en-us/dotnet/api/system.exception.innerexception?view=net-9.0#system-exception-innerexception?

[rosieks]

How InnerException suppose to be related to reason? Reason is just plain text description what caused the error.

[liskin]

Oh, sorry, I must have been drunk when looking at this. On second look this all makes sense. Apologies again!

[liskin]

Sorry again about the confusion earlier! After a good night's sleep, this all makes sense and looks like it's a very good solution. I'd consider adding a test checking that ToString contains the inner exception as well, but otherwise this is perfect.

[rosieks]

Testing ToString doesn't make sense. It's inherited behavior and it's tested already somewhere else.

[liskin]

Testing ToString doesn't make sense. It's inherited behavior and it's tested already somewhere else.

Suppose that's right. I saw it as a way to express "desired behavior". Sure, it's obvious that the code does what it should, it's a typed language, but having a test case saying "YamlException stringification doesn't hide the inner exception" seemed as a useful regression test. Doesn't matter that much though.

[benPearce1]

Any chance of getting this merged?