Add iterator for tokens sorted by probability #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ucyo
commented
Oct 12, 2022
Comment on lines
+60
to
+61
| pub trait Chainable: Eq + Hash + Clone + Debug {} | ||
| impl<T> Chainable for T where T: Eq + Hash + Clone + Debug {} |
There was a problem hiding this comment.
Remove Debug statements in final PR
Comment on lines
+121
to
+122
| println!("Tokens {:?}", toks); | ||
| println!("Map {:?}", self.map); |
There was a problem hiding this comment.
Remove prints or replace with logs in final PR
Comment on lines
+118
to
+123
| if !self.map.contains_key(&toks) { | ||
| return Vec::new(); | ||
| } | ||
| println!("Tokens {:?}", toks); | ||
| println!("Map {:?}", self.map); | ||
| let result = self.map.get(&toks).unwrap(); |
There was a problem hiding this comment.
Combine contains_key and unwrap call in a match statement
Comment on lines
133
to
135
| pub fn iter_rank<S: AsRef<[T]>>(&self, tokens: S) -> RankIterator<T> { | ||
| RankIterator::new(self, tokens) | ||
| } |
There was a problem hiding this comment.
Add feature to specify a token to be searched for and return its rank eg. iterate over all tokens of token a as predecessor and search for token b and return its rank
|
|
||
| #[derive(Debug)] | ||
| /// Iterator over tokens sorted by rank given a token (sorted by highest probability) | ||
| pub struct RankIterator<'a, T> |
There was a problem hiding this comment.
Maybe rename to something more specific? Maybe ProbabilityIterator or SortedRankIterator?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a compression library we need an iterator over all tokens sorted by its probability. This PR adds this feature.