New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't allow unsafe characters in URLs #121

Merged

aarongustafson merged 1 commit into aarongustafson:master from maxandersen:fixlinks

Jan 9, 2019

Contributor

maxandersen commented Dec 26, 2018

Why:

asciidoc files has links like http://example.com[Example] which
currently when parsed includes the [Example] section
This causes errors when parsing the url later on.

This change addreses the need by:

Add unsafe characters to the exclusin in the regular expression match
See https://perishablepress.com/stop-using-unsafe-characters-in-urls/

Fixes #120


          Don't allow unsafe characters in URLs

5b9bd71

Why:

 * asciidoc files has links like http://example.com[Example] which
   currently when parsed includes the [Example] section
 * This causes errors when parsing the url later on.

This change addreses the need by:

 * Add unsafe characters to the exclusin in the regular expression match
   See https://perishablepress.com/stop-using-unsafe-characters-in-urls/

maxandersen mentioned this pull request

jekyll webmention required use of md #120

Closed

Owner

aarongustafson commented Jan 9, 2019

Looks good

aarongustafson merged commit 9ea862d into aarongustafson:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet