Fixed block comments#457
Open
aarondill wants to merge 1 commit into
Open
Conversation
Author
|
@aaron-bond, I’m wondering if you’ve noticed either of my recent pull requests(or their corresponding issues)? they each fix inconsistencies and allow for use of this extension in more areas without extra effort from the user(such as dis-allowing single line block comments) |
Owner
|
Yeah, I'd seen these come in. There's quite a bit of regression testing involved (shame on me for not automating the shit out of this) which is my main blocker when it comes to PRs. The thing is that these requests usually end up changing a behaviour someone requested in the past, so it's a tricky balance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #456 by rewriting regular expressions for block comments.
Known Bugs:
Whitespace directly before a block comment is required(as it was before). This was maintained to make it harder to accidentally create "ghost" blocks, where an open tag occurs within an inline comment, causing future lines to appear styled when they shouldn't. This bug is still easily recreatable by typing
// /*but is unlikely to affect many users in it's current state.Additional Considerations:
An attempt was made to keep the code as similar as possible to the original, as well as keep consistency with inline comments. As such, the openings of block comments are styled with the first tag, if one occurs on the same line as the opening.
A star(*) immediately following the commentBlockStart will not be considered a multiline comment for the sake of later parsing JSdoc comments, so my patches don't apply to any comment that starts with a star(*).
I have tested this patch with JavaScript, HTML, and Python, but a more thorough testing with other languages is both welcome and encouraged.