Skip to content

Commit

Permalink
perf report: Add --comms parameter
Browse files Browse the repository at this point in the history
So that we can filter by comm. Symbols in other comms won't be
accounted for.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Paul Mackerras <paulus@samba.org>
LKML-Reference: <1246399282-20934-3-git-send-email-acme@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
  • Loading branch information
acmel authored and Ingo Molnar committed Jun 30, 2009
1 parent 2590340 commit cc8b88b
Show file tree
Hide file tree
Showing 2 changed files with 27 additions and 10 deletions.
4 changes: 4 additions & 0 deletions tools/perf/Documentation/perf-report.txt
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,10 @@ OPTIONS
--dsos=::
Only consider symbols in these dsos. CSV that understands
file://filename entries.
-C::
--comms=::
Only consider symbols in these comms. CSV that understands
file://filename entries.

SEE ALSO
--------
Expand Down
33 changes: 23 additions & 10 deletions tools/perf/builtin-report.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ static char *vmlinux = NULL;

static char default_sort_order[] = "comm,dso";
static char *sort_order = default_sort_order;
static char *dso_list_str;
static struct strlist *dso_list;
static char *dso_list_str, *comm_list_str;
static struct strlist *dso_list, *comm_list;

static int input;
static int show_mask = SHOW_KERNEL | SHOW_USER | SHOW_HV;
Expand Down Expand Up @@ -240,7 +240,7 @@ static u64 vdso__map_ip(struct map *map, u64 ip)

static inline int is_anon_memory(const char *filename)
{
return strcmp(filename, "//anon") == 0;
return strcmp(filename, "//anon") == 0;
}

static struct map *map__new(struct mmap_event *event)
Expand Down Expand Up @@ -1253,6 +1253,9 @@ process_sample_event(event_t *event, unsigned long offset, unsigned long head)
return -1;
}

if (comm_list && !strlist__has_entry(comm_list, thread->comm))
return 0;

if (event->header.misc & PERF_EVENT_MISC_KERNEL) {
show = SHOW_KERNEL;
level = 'k';
Expand Down Expand Up @@ -1667,6 +1670,8 @@ static const struct option options[] = {
OPT_BOOLEAN('c', "callchain", &callchain, "Display callchains"),
OPT_STRING('d', "dsos", &dso_list_str, "dso[,dso...]",
"only consider symbols in these dsos"),
OPT_STRING('C', "comms", &comm_list_str, "comm[,comm...]",
"only consider symbols in these comms"),
OPT_END()
};

Expand All @@ -1685,6 +1690,19 @@ static void setup_sorting(void)
free(str);
}

static void setup_list(struct strlist **list, const char *list_str,
const char *list_name)
{
if (list_str) {
*list = strlist__new(true, list_str);
if (!*list) {
fprintf(stderr, "problems parsing %s list\n",
list_name);
exit(129);
}
}
}

int cmd_report(int argc, const char **argv, const char *prefix)
{
symbol__init();
Expand All @@ -1706,13 +1724,8 @@ int cmd_report(int argc, const char **argv, const char *prefix)
if (argc)
usage_with_options(report_usage, options);

if (dso_list_str) {
dso_list = strlist__new(true, dso_list_str);
if (!dso_list) {
fprintf(stderr, "problems parsing dso list\n");
exit(129);
}
}
setup_list(&dso_list, dso_list_str, "dso");
setup_list(&comm_list, comm_list_str, "comm");

setup_pager();

Expand Down

0 comments on commit cc8b88b

Please sign in to comment.