Skip to content

Commit

Permalink
ASoC: wm_adsp: Acknowledge controls should also check the DSP is running
Browse files Browse the repository at this point in the history
We should not be writing acknowledge controls until the firmware is
running, as in the case of preloaded firmwares the DSP memory may be
unaccessible to whilst in the preloaded state. This means a write to the
control during this time could be lost.

Signed-off-by: Charles Keepax <ckeepax@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
  • Loading branch information
charleskeepax authored and broonie committed Mar 7, 2017
1 parent 67430a3 commit 7b4af79
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion sound/soc/codecs/wm_adsp.c
Original file line number Diff line number Diff line change
Expand Up @@ -952,7 +952,7 @@ static int wm_coeff_put_acked(struct snd_kcontrol *kctl,

mutex_lock(&ctl->dsp->pwr_lock);

if (ctl->enabled)
if (ctl->enabled && ctl->dsp->running)
ret = wm_coeff_write_acked_control(ctl, val);
else
ret = -EPERM;
Expand Down

0 comments on commit 7b4af79

Please sign in to comment.