Skip to content

Commit

Permalink
logfs: remove unnecessary dentry_unhash from rmdir, dir rename
Browse files Browse the repository at this point in the history
logfs does not have problems with references to unlinked directories.

CC: Joern Engel <joern@logfs.org>
CC: logfs@logfs.org
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
liewegas authored and Al Viro committed May 28, 2011
1 parent 44a8e63 commit 64370e2
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/logfs/dir.c
Original file line number Diff line number Diff line change
Expand Up @@ -273,8 +273,6 @@ static int logfs_rmdir(struct inode *dir, struct dentry *dentry)
{
struct inode *inode = dentry->d_inode;

dentry_unhash(dentry);

if (!logfs_empty_dir(inode))
return -ENOTEMPTY;

Expand Down Expand Up @@ -624,9 +622,6 @@ static int logfs_rename_cross(struct inode *old_dir, struct dentry *old_dentry,
loff_t pos;
int err;

if (new_dentry->d_inode && S_ISDIR(new_dentry->d_inode->i_mode))
dentry_unhash(new_dentry);

/* 1. locate source dd */
err = logfs_get_dd(old_dir, old_dentry, &dd, &pos);
if (err)
Expand Down

0 comments on commit 64370e2

Please sign in to comment.