Skip to content

Commit

Permalink
[BRIDGE]: Fix faulty check in br_stp_recalculate_bridge_id()
Browse files Browse the repository at this point in the history
One of the conversions from memcmp to compare_ether_addr is incorrect.
We need to do relative comparison to determine min MAC address to
use in bridge id. 

Signed-off-by: Stephen Hemminger <shemminger@osdl.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Stephen Hemminger authored and davem330 committed Jan 3, 2006
1 parent e84a9f5 commit 554c9a8
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion net/bridge/br_stp_if.c
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ void br_stp_recalculate_bridge_id(struct net_bridge *br)

list_for_each_entry(p, &br->port_list, list) {
if (addr == br_mac_zero ||
compare_ether_addr(p->dev->dev_addr, addr) < 0)
memcmp(p->dev->dev_addr, addr, ETH_ALEN) < 0)
addr = p->dev->dev_addr;

}
Expand Down

0 comments on commit 554c9a8

Please sign in to comment.