Skip to content

Commit

Permalink
PNP: mark resources that conflict with PCI devices "disabled"
Browse files Browse the repository at this point in the history
Both the PNP/PCI conflict detection quirk and the PNP system
driver must use the same mechanism to mark resources as disabled.

I think it's best to keep the resource and to keep the type bit
(IORESOURCE_MEM, etc), so that we match the list from firmware
as closely as possible.

Fixes this regression from 2.6.25: http://lkml.org/lkml/2008/6/1/82

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Tested-by: Avuton Olrich <avuton@gmail.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Bjorn Helgaas authored and torvalds committed Jun 2, 2008
1 parent c3b25b3 commit 4b34fe1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/pnp/quirks.c
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ static void quirk_system_pci_resources(struct pnp_dev *dev)
pci_name(pdev), i,
(unsigned long long) pci_start,
(unsigned long long) pci_end);
res->flags = 0;
res->flags |= IORESOURCE_DISABLED;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion drivers/pnp/system.c
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ static void reserve_resources_of_dev(struct pnp_dev *dev)
}

for (i = 0; (res = pnp_get_resource(dev, IORESOURCE_MEM, i)); i++) {
if (res->flags & IORESOURCE_UNSET)
if (res->flags & IORESOURCE_DISABLED)
continue;

reserve_range(dev, res->start, res->end, 0);
Expand Down

0 comments on commit 4b34fe1

Please sign in to comment.