Skip to content

Commit

Permalink
hpfs: remove unnecessary dentry_unhash on rmdir, dir rename
Browse files Browse the repository at this point in the history
Hpfs has no problems with references to unlinked directories.

We leave one dentry_unhash call in place, in hpfs_unlink's strange path
where it tries to truncate a file because the disk is full.  I'm not sure
what the full story is there.

CC: Mikulas Patocka <mikulas@artax.karlin.mff.cuni.cz>
Signed-off-by: Sage Weil <sage@newdream.net>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
liewegas authored and Al Viro committed May 28, 2011
1 parent b80d2c2 commit 45adfef
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions fs/hpfs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -439,8 +439,6 @@ static int hpfs_rmdir(struct inode *dir, struct dentry *dentry)
int err;
int r;

dentry_unhash(dentry);

hpfs_adjust_length(name, &len);
hpfs_lock(dir->i_sb);
err = -ENOENT;
Expand Down Expand Up @@ -535,9 +533,6 @@ static int hpfs_rename(struct inode *old_dir, struct dentry *old_dentry,
struct fnode *fnode;
int err;

if (new_inode && S_ISDIR(new_inode->i_mode))
dentry_unhash(new_dentry);

if ((err = hpfs_chk_name(new_name, &new_len))) return err;
err = 0;
hpfs_adjust_length(old_name, &old_len);
Expand Down

0 comments on commit 45adfef

Please sign in to comment.