Skip to content

Commit

Permalink
.github: Fix missing variable escaping in LVH command
Browse files Browse the repository at this point in the history
This fixes an issue with the tests-e2e-upgrade workflow where the
`${EXTRA{@}}` arguments were actually empty, because commands are bash
expanded on the host runner, i.e. before they are passed to the LVH VM. As a
result, the additional arguments were ignored.

This fix is only applied to v1.15 because other branches use different
methods for passing in `cilium connectivity check` command.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
  • Loading branch information
gandro committed Nov 12, 2024
1 parent 9365d9c commit 6446b64
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/tests-e2e-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ jobs:
--sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-<ts>" \
--junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \
--junit-property github_job_step="Run tests upgrade 2 (${{ join(matrix.*, ', ') }})" \
"${EXTRA[@]}"
"\${EXTRA[@]}"
# --flush-ct interrupts the flows, so we need to set up again.
./cilium-cli connectivity test --include-conn-disrupt-test --conn-disrupt-test-setup \
Expand Down Expand Up @@ -579,7 +579,7 @@ jobs:
--sysdump-output-filename "cilium-sysdump-${{ matrix.name }}-<ts>" \
--junit-file "cilium-junits/${{ env.job_name }} (${{ join(matrix.*, ', ') }}).xml" \
--junit-property github_job_step="Run tests upgrade 3 (${{ join(matrix.*, ', ') }})" \
"${EXTRA[@]}"
"\${EXTRA[@]}"
- name: Fetch artifacts
if: ${{ !success() }}
Expand Down

0 comments on commit 6446b64

Please sign in to comment.