Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add EnclosingMethod proguard rule #283

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Add EnclosingMethod proguard rule #283

merged 1 commit into from
Dec 15, 2023

Conversation

rafsanjani
Copy link
Contributor

@rafsanjani rafsanjani commented Dec 13, 2023

Q A
Bug fix? no
New feature? no
BC breaks? no

Describe your change

Add an extra proguard rule -keepattributes EnclosingMethod which is required by the InnerClasses attribute rule.

What problem is this fixing?

On Android, the -keepattributes InnerClasses proguard rule complains about missing EnclosingMethod attribute causing release builds with minification enabled to fail.

@aallam
Copy link
Owner

aallam commented Dec 15, 2023

Thank you for your contribution!

@aallam aallam merged commit 93383c1 into aallam:main Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants