Skip to content

Commit

Permalink
Add aria-label to articles page's CTA (forem#1004)
Browse files Browse the repository at this point in the history
In the main articles page CTA for signing in via Twitter or Github, previously, screen readers say "Twitter" and "GitHub."  I added an `aria-label` attribute so that screen readers will say "Sign in with Twitter" and "Sign in with GitHub."  Tested on Windows 7, in Chrome, using Chrome Vox extension, and works well!
  • Loading branch information
rpalo authored and maestromac committed Oct 25, 2018
1 parent 85b18c5 commit 3160473
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions app/views/articles/_main_stories_feed.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,10 @@
<% end %>
</h2>
<div class="button-container">
<a href="/users/auth/twitter?callback_url=<%= ApplicationConfig["APP_PROTOCOL"] %><%= ApplicationConfig["APP_DOMAIN"] %>/users/auth/twitter/callback" class="cta cta-button" data-no-instant>
<a href="/users/auth/twitter?callback_url=<%= ApplicationConfig["APP_PROTOCOL"] %><%= ApplicationConfig["APP_DOMAIN"] %>/users/auth/twitter/callback" class="cta cta-button" aria-label="Sign in with Twitter." data-no-instant>
TWITTER
</a>
<a href="/users/auth/github?state=in-feed-cta" class="cta cta-button" data-no-instant>
<a href="/users/auth/github?state=in-feed-cta" class="cta cta-button" aria-label="Sign in with GitHub." data-no-instant>
GITHUB
</a>
</div>
Expand Down

0 comments on commit 3160473

Please sign in to comment.