Batch (parallelized) calculations of beta Shapley #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosmitive
force-pushed
the
feature/427-batch-parallelized-calculations-of-beta-shapley
branch
2 times, most recently
from
121ff42
to
0cdbc3e
Compare
…e_beta_shapley_semivalues`, `compute_shapley_semivalues` and `compute_generic_semivalues`.
kosmitive
force-pushed
the
feature/427-batch-parallelized-calculations-of-beta-shapley
branch
from
0cdbc3e
to
0914b66
Compare
added 2 commits
September 6, 2023 02:27
…ovement compared to a singular batch size.
|
This might not be the right direction in which to go, even if it indeed helps in some situations. See my comments in the issue. |
AnesBenmerzoug
previously approved these changes
Sep 8, 2023
There was a problem hiding this comment.
Looks good to me. @mdbenito do you still want to put comments saying that this is not final yet and it may be remove? If yes, where would you put them?
mdbenito
reviewed
Sep 9, 2023
There was a problem hiding this comment.
@kosmitive After resolving conflicts, all that would be left to do is to very clearly document that batch size will be deprecated in the future. Note that adding the deprecation decorator generates a runtime warning but is not seen in the documentation, so please add it to the docstring as well.
…parallelized-calculations-of-beta-shapley # Conflicts: # tests/value/test_semivalues.py
kosmitive
force-pushed
the
feature/427-batch-parallelized-calculations-of-beta-shapley
branch
from
5e56dd5
to
9083bc2
Compare
…ns-of-beta-shapley
mdbenito
approved these changes
Sep 18, 2023
mdbenito
deleted the
feature/427-batch-parallelized-calculations-of-beta-shapley
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR closes #427
Changes
batch_sizeparameter tocompute_banzhaf_semivalues,compute_beta_shapley_semivalues,compute_shapley_semivaluesandcompute_generic_semivalues.Checklist