Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: increase codecov #105

Merged
merged 2 commits into from
Aug 4, 2021
Merged

chore: increase codecov #105

merged 2 commits into from
Aug 4, 2021

Conversation

mzdm
Copy link
Collaborator

@mzdm mzdm commented Jun 21, 2021

let's get 100%

Edit: almost 😃

The uncovered lines seem to be unreachable through. I'll re-check it someday.

@mzdm mzdm changed the title chore: increase codeov [WIP] chore: increase codecov [WIP] Jun 21, 2021
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 02ebc19):

https://introviews-flutter--pr105-update-tests-se2gu82e.web.app

(expires Wed, 21 Jul 2021 20:03:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@codecov
Copy link

codecov bot commented Jun 21, 2021

Codecov Report

Merging #105 (02ebc19) into master (b04fb87) will increase coverage by 3.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #105      +/-   ##
==========================================
+ Coverage   94.61%   98.36%   +3.74%     
==========================================
  Files          16       16              
  Lines         427      427              
==========================================
+ Hits          404      420      +16     
+ Misses         23        7      -16     
Impacted Files Coverage Δ
lib/src/ui/page_indicator_buttons.dart 96.70% <ø> (+3.29%) ⬆️
lib/src/animation_gesture/page_dragger.dart 100.00% <0.00%> (+6.25%) ⬆️
lib/src/ui/intro_views_flutter.dart 100.00% <0.00%> (+8.57%) ⬆️
...b/src/animation_gesture/animated_page_dragger.dart 100.00% <0.00%> (+9.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b04fb87...02ebc19. Read the comment docs.

@mzdm mzdm marked this pull request as ready for review July 12, 2021 17:43
@mzdm
Copy link
Collaborator Author

mzdm commented Jul 12, 2021

oops I totally forgot about this.

@mzdm mzdm requested a review from aagarwal1012 July 12, 2021 17:44
@mzdm mzdm changed the title chore: increase codecov [WIP] chore: increase codecov Jul 12, 2021
Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Sorry I completely missed it. 😅

@aagarwal1012 aagarwal1012 merged commit d257e0a into master Aug 4, 2021
@aagarwal1012 aagarwal1012 deleted the update-tests branch August 4, 2021 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants