Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run Firebase preview workflow only on the upstream repo branches #101

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

mzdm
Copy link
Collaborator

@mzdm mzdm commented Jun 11, 2021

Runs Firebase preview CI workflow only on the upstream repository branches so we don't get failing checks, which might be confusing.

Test PR from my forked repo #100.

@mzdm mzdm requested a review from aagarwal1012 June 11, 2021 18:51
@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #101 (ccc2fe1) into master (739d40e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #101   +/-   ##
=======================================
  Coverage   93.94%   93.94%           
=======================================
  Files          15       15           
  Lines         413      413           
=======================================
  Hits          388      388           
  Misses         25       25           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739d40e...ccc2fe1. Read the comment docs.

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit ccc2fe1):

https://introviews-flutter--pr101-dev-747ns710.web.app

(expires Sun, 11 Jul 2021 18:53:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Copy link
Owner

@aagarwal1012 aagarwal1012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aagarwal1012 aagarwal1012 merged commit 6a90108 into master Jun 11, 2021
@aagarwal1012 aagarwal1012 deleted the dev branch June 11, 2021 19:11
@mzdm
Copy link
Collaborator Author

mzdm commented Jun 16, 2021

@aagarwal1012 do you prefer doing small minor releases after each minor change (like this CI change) or some major version releases which would include a group of changes at once (like the 3.2.0 version)?

@aagarwal1012
Copy link
Owner

Actually, I prefer a major change release, but if some minor change is important, its release can be done. Let me know what do you prefer.

@mzdm
Copy link
Collaborator Author

mzdm commented Jun 16, 2021

Actually, I prefer a major change release, but if some minor change is important, its release can be done. Let me know what do you prefer.

Yup, same here. This way I don't need to remember to update the changelog & version after each minor change all the time, but do it once after a while.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants