-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue #12 #16
base: master
Are you sure you want to change the base?
Fix Issue #12 #16
Conversation
Hi @aadeshkulkarni The PR is ready for review. |
@asad0206 - This looks okay, but it needs to be visually stimulating. Also, there are a lot of formatting changes in your PR. Can you please rollback them so that it's easier to review your changes, please ? At the moment, it's difficult to figure out which is a formatting change and which is PR related. Thank you. |
Can you tell me what other changes would u like in the UI? any details for what i can add. And I will also try to fix the changes in PR. please give me some time. |
7782d41
to
45a0279
Compare
@aadeshkulkarni can you please check the PR now ? |
@asad0206 - Please remove images (png, jpg, etc.) from the background as that adds performance problems due to longer loading time. Use bg gradients or svgs Some references: |
*Fix issue #12
Please check the file and the UI design.
I have checked for the responsiveness of the page. In case of any missed out bugs you can let me know.
Made the uploader page a separate component so the main "PAGE.TSX" file remains clean.
I did not install any of the backend as i was confused. Please provide help if you can