Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue #12 #16

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

asad0206
Copy link

*Fix issue #12

  • Add: Upload Page Redesign
  • Added components: ShadCN Card component
  • File Edited: page.tsx, components/ui/upload.tsx

Please check the file and the UI design.
I have checked for the responsiveness of the page. In case of any missed out bugs you can let me know.
Made the uploader page a separate component so the main "PAGE.TSX" file remains clean.
I did not install any of the backend as i was confused. Please provide help if you can

localhost_3000_

@asad0206
Copy link
Author

Hi @aadeshkulkarni The PR is ready for review.

@aadeshkulkarni
Copy link
Owner

@asad0206 - This looks okay, but it needs to be visually stimulating.

Also, there are a lot of formatting changes in your PR. Can you please rollback them so that it's easier to review your changes, please ?

At the moment, it's difficult to figure out which is a formatting change and which is PR related.

Thank you.

@asad0206
Copy link
Author

Can you tell me what other changes would u like in the UI? any details for what i can add.

And I will also try to fix the changes in PR. please give me some time.

@asad0206
Copy link
Author

asad0206 commented Sep 19, 2024

  • I have tried to address all the issues
  • Added 2 images for background so that it looks appealing
  • Changed the Glassmorphic card from Slate theme to white theme to make it visible with darker backgrounds

an example it given below

image

@asad0206
Copy link
Author

@aadeshkulkarni can you please check the PR now ?

@aadeshkulkarni
Copy link
Owner

@asad0206 - Please remove images (png, jpg, etc.) from the background as that adds performance problems due to longer loading time.

Use bg gradients or svgs

Some references:
https://dribbble.com/shots/22782075-Upload-Modal
https://www.epicweb.dev/tips/creating-glassmorphism-effects-with-tailwind-css
https://tailwindcss-glassmorphism.vercel.app/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants