Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Style Issue | Improve profile box #66

Closed
KrupaPanchal2527 opened this issue May 20, 2024 · 8 comments
Closed

Style Issue | Improve profile box #66

KrupaPanchal2527 opened this issue May 20, 2024 · 8 comments
Assignees
@KrupaPanchal2527
Labels
bug Something isn't working frontend

Comments

@KrupaPanchal2527
Copy link
Contributor

The profile box (top-right corner) doesn't close when clicked outside. Use a popover or menu to render the profile box.

Medium Blog · 5 39pm · 05-20
@KrupaPanchal2527
Copy link
Contributor Author

@aadeshkulkarni Please assign this to me.

@aadeshkulkarni
Copy link
Owner

Done

@aadeshkulkarni aadeshkulkarni added bug Something isn't working frontend labels May 20, 2024
KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 21, 2024
@KrupaPanchal2527
Add shadcn library
652a747 
[Issue aadeshkulkarni#66](aadeshkulkarni#66)
KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 21, 2024
@KrupaPanchal2527
Replaced current profile box with shadcn dropdown for better accessib…
7cdee04 
…ility

[Issue aadeshkulkarni#66](aadeshkulkarni#66)
KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 21, 2024
@KrupaPanchal2527
Replaced current profile box with shadcn dropdown for better accessib…
c1164a9 
…ility

[Issue aadeshkulkarni#66](aadeshkulkarni#66)
KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 22, 2024
@KrupaPanchal2527
Add shadcn library
fd4347c 
[Issue aadeshkulkarni#66](aadeshkulkarni#66)
KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 22, 2024
@KrupaPanchal2527
Replaced current profile box with shadcn dropdown for better accessib…
2c7f763 
…ility

[Issue aadeshkulkarni#66](aadeshkulkarni#66)
KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 22, 2024
@KrupaPanchal2527
Fix up styles overwritten
fe11be2 
[Issue aadeshkulkarni#66](aadeshkulkarni#77)
@KrupaPanchal2527 KrupaPanchal2527 mentioned this issue May 22, 2024
Closed
@KrupaPanchal2527
Copy link
Contributor Author

@aadeshkulkarni I have added shadcn UI library for this purpose. I hope that's fine. If we don't want to bring in any UI library at this point, I can open another PR with a manual fix.

PR #79

@aadeshkulkarni
Copy link
Owner

In two minds regarding shadcn.
If we use it, we might have to refactor some atomic components throughout the frontend.

Having said that, shadcn has a lot of cool things and would be useful and we should implement it.
But, if we integrate it right now, code refactoring might be needed.

Keeping this as a tech backlog for the near future.

Would be great if you do this without shadcn

@KrupaPanchal2527
Copy link
Contributor Author

Okay, I'll do that.

@KrupaPanchal2527
Copy link
Contributor Author

Shall I close the current PR related to this?

@aadeshkulkarni
Copy link
Owner

Yes, please.

KrupaPanchal2527 added a commit to KrupaPanchal2527/medium-app-opensourcing that referenced this issue May 23, 2024
@KrupaPanchal2527
[Fix]: Make profile box close when clicked outside
7b9151b 
[Issue aadeshkulkarni#66](aadeshkulkarni#66)
@KrupaPanchal2527 KrupaPanchal2527 mentioned this issue May 23, 2024
Merged
@KrupaPanchal2527
Copy link
Contributor Author

Opened a PR with manual fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KrupaPanchal2527 KrupaPanchal2527

Labels
bug Something isn't working frontend
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@KrupaPanchal2527 @aadeshkulkarni