Repository navigation
Keep macOS wake capture at real-time speed across resumes - #2
Merged
Merged
Conversation
Preserve the 25-block/7-second gate while recording bounded PCM, acknowledgement and Web Audio clock evidence. Exercise four resume cycles in native package verification. Co-authored-by: ChatGPT <noreply@openai.com>
Use Chromium's silent AudioContext sink for input-only wake analysis. Preserve the 16 kHz PCM and acknowledgement path. Keep optional CDP clock diagnostics disabled during normal native package acceptance. Co-authored-by: ChatGPT <noreply@openai.com>
Request a 0.1-second latency hint for the software-clocked silent output. Native ARM and Intel comparisons confirm near-real-time PCM across four resume cycles. Require steady PCM cadence as well as the existing count deadline so a continuously slow stream cannot pass package acceptance. Co-authored-by: ChatGPT <noreply@openai.com>
aaamosh
marked this pull request as ready for review
October 5, 2026 16:14
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The first post-merge macOS run exposed an intermittent wake-capture failure: after resume, the ARM runner delivered only 18 of the required 25 PCM blocks within seven seconds. All delivered blocks were acknowledged; the detector was ready and its queue stayed empty.
Failing main run
Timing instrumentation then reproduced a running Web Audio context whose render clock advanced only 8–16 ms during roughly 500 ms of wall time. This localizes the problem to audio rendering rather than Python backpressure or a changed wall clock; it does not establish the exact internal CoreAudio/Chromium defect.
Changes
The renderer regression test still checks selected microphone input, unmodified nonzero PCM, acknowledgements, and cleanup. New cadence tests reject a continuously slow stream even when it meets the old count deadline.
Native investigation and rejected intermediate candidate
A silent sink with the default interactive buffer passed the old count-only gates, but delivered audio substantially slower than real time. Commit
6f4695cwas therefore not accepted for release despite green CI. A live input FIFO can discard audio when its consumer falls behind.A same-host, sequential comparison with debugging disabled then tested the default output and silent outputs with explicit buffer requests on both architectures:
The PCM interval represented is 2.4 s. The 0.25-second hint also worked in the comparison; the smaller tested request was sufficient. These diagnostic comparisons inform the fix and do not replace full package acceptance.
Both native comparisons
Validation
Final source:
fe50d2596c72d92a875c71086ce9283eb12ce1e5.99f44807c8b80dfb69a56601b3501137ac0ecde0, whose tree64e6adff11dcd11cb3e3aaebcbbe1bf123602375exactly matches the final PR head.Merged as
f5520ecf1b9d170d086698a4ed665de45685146e. The published Preview 2 and its additional post-merge validation are recorded below.Post-merge release validation and publication
The first Preview 2 publication run stopped before creating a release. In run 37339490068, ARM passed the strengthened PCM pipeline and nine other gates, but GUI wake startup failed at approximately its 15-second deadline. The existing report could not identify the unfinished startup operation. Intel separately failed while downloading Electron, followed by repeated artifact-service network timeouts.
Released source
0b9924badds bounded, local startup-stage evidence and requires four fresh GUI captures, preserving the original deadlines and immediate cancellation. Packaging reuses cached Electron archives with checksums from the pinned npm package, avoiding a second remote checksum request. The primary download still requires network access. These additions do not establish the cause of the isolated GUI startup timeout.The first publisher attempt created an empty draft and stopped on its immediate metadata readback. Later independent reads matched the exact source, title, notes, author and empty asset inventory. Only that publisher job was resumed, using the same original run artifacts. Job 111878337803 succeeded, verifying all seven uploaded sizes and SHA-256 digests before publication. The original mismatching API response was not retained; its precise cause remains undetermined.
Download macOS Preview 2. The public tag resolves to the exact tested source
0b9924b014d4c46271647e95d97806811fb45229. All seven assets and the release body were read back after publication. Preview 1's tag, notes, sizes and digests remain unchanged. Closeoutbe423d5retires the completed publication job and adds direct README downloads.These are ad-hoc signed previews tested with synthetic audio on macOS 15. Ventura runtime, physical devices, real permission prompts, sleep/unplug recovery, user-session Login Items and real account calls remain hands-on acceptance items.
Final main verification
Final main commit
be423d51a8974627d66b98a5c63a27199cecbefdpassed Linux CI and both native macOS jobs on their first attempt. All three logs explicitly report 404 tests passed, zero failures or skips; both Mac builds pass all 11 package gates, four fresh GUI captures, four pipeline resumes, cadence checks, and clean teardown. The native job definition and application runtime are unchanged from the released source by this documentation/workflow closeout.All seven public Preview 2 files were independently downloaded over anonymous HTTPS, with HTTP 200, exact byte counts and SHA-256 matching GitHub metadata. All six entries in the downloaded
SHA256SUMSmatch the streamed bytes, and both downloaded manifests identify the clean released source0b9924b014d4c46271647e95d97806811fb45229. No native binaries were rebuilt for publication recovery.